Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Tor
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Container Registry
Model registry
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
The Tor Project
Core
Tor
Commits
f81ad155
Commit
f81ad155
authored
21 years ago
by
Roger Dingledine
Browse files
Options
Downloads
Patches
Plain Diff
note an assert trigger bug
nick, want to fix this? :) svn:r1192
parent
c0b5002d
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/or/connection_edge.c
+7
-0
7 additions, 0 deletions
src/or/connection_edge.c
with
7 additions
and
0 deletions
src/or/connection_edge.c
+
7
−
0
View file @
f81ad155
...
...
@@ -868,6 +868,13 @@ static int connection_exit_begin_conn(cell_t *cell, circuit_t *circ) {
case
-
1
:
/* resolve failed */
log_fn
(
LOG_INFO
,
"Resolve failed (%s)."
,
n_stream
->
address
);
connection_mark_for_close
(
n_stream
,
END_STREAM_REASON_RESOLVEFAILED
);
/* XXX BUG: we're in state RESOLVING here, but we haven't been added to the
* 'pending' list, because the dns lookup was already cached as failed.
* But the mark_for_close will try to remove us from the pending list,
* and we'll trigger an assert (dns.c line 209).
* Should we add another EXIT_CONN state? Should we put an exception
* here? Or there?
*/
/* case 0, resolve added to pending list */
}
return
0
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment