Extend cells aren't allowed to have a stream_id, but we were only
blocking them when they had a stream_id that corresponded to a
connection.  As far as I can tell, this change is harmless: it will
make some kinds of broken clients not work any more, but afaik nobody
actually make a client that was broken in that way.

Found while hunting for other places where we made the same mistake
as in 6271.

Bugfix on d7f50337 back from May 2003, which introduced
telescoping circuit construction into 0.0.2pre8.

This function never actually did us any good, and it added a little
complexity.  See the changes file for more info.

And more to the point, some GCCs will warn that you can't say it
before C90.

Bug not in any released version of Tor.

Conflicts:
	src/or/routerlist.c

I don't personally agree that this is likely to be easy to exploit,
and some initial experimention I've done suggests that cache-miss
times are just plain too fast to get useful info out of when they're
mixed up with the rest of Tor's timing noise.  Nevertheless, I'm
leaving Robert's initial changelog entry in the git history so that he
can be the voice of reason if I'm wrong. :)

Robert Ransom authored 12 years ago and Nick Mathewson committed 12 years ago

Tor's and OpenSSL's current design guarantee that there are other leaks,
but this one is likely to be more easily exploitable, and is easy to fix.

Fix for 6530; fix on 0.2.2.6-alpha.

The values are only being checked, not modified.

Stewart Smith authored 12 years ago and Nick Mathewson committed 12 years ago

This makes the V=1 or V=0 automake silent build options display (or hide)
the full command line used.

  GEN foo.bar

will be seen rather than the full command.

As with all automake silent rules, "make V=1" will output the full command.

Stewart Smith authored 12 years ago and Nick Mathewson committed 12 years ago

$ make V=1 # will temporarily disable them

otherwise you see:

   CC foo.c

rather than the giant long bulid line.

This makes it significantly easier to spot compiler warnings etc.

Additionally, make them conditional, so we won't error on automake <
1.11

(commits squashed by nickm.)

I can't currently find a bug here, but there are a couple of
near-misses.  Addresses ticket 6514; reported pseudonymously on
IRC.

Fixes 6480; fix on 0.2.0.1-alpha; based on pseudonymous patch.

Two of the do_*_test functions were actually prefixes of the third,
which suggests a trivial code elimination step