Spotted by coverity; bug in tests only, not in any released Tor.

This is CID 1351128

Fixes failures in test_config.c; bug not in any released tor.

teor (Tim Wilson-Brown) authored 9 years ago and Nick Mathewson committed 9 years ago

This avoids a potential out of bounds write.

Ola Bini authored 9 years ago and Nick Mathewson committed 9 years ago

Add a helper to search for strings in the log, and change option tests to use this helper instead of looking at specific indices in the log list

(We already had a fix for the address test freebsd issues)

In jails, there is not always a localhost.

Bugfix not on any released Tor.

Based on text from s7r

Closes #17839.

Avoid using a pronoun where it makes comments unclear.
Avoid using gender for things that don't have it.
Avoid assigning gender to people unnecessarily.

Avoid using gender for things that don't have it.

Avoid using gender for things that don't have it.

Avoid assigning a gender to tor users.

We still silently ignore
     memwipe(NULL, ch, 0);
and
     memwipe(ptr, ch, 0);  /* for ptr != NULL */

But we now assert on:
     memwipe(NULL, ch, 30);

teor (Tim Wilson-Brown) authored 9 years ago and Nick Mathewson committed 9 years ago

Allow fallback directories which have been stable for 30 days
to work around #18050, which causes relays to submit descriptors
with 0 DirPorts when restarted. (Particularly during Tor version
upgrades.)

Ignore low fallback directory count in alpha builds.