Fixes #27040

Signed-off-by: David Goulet <dgoulet@torproject.org>

Before 0.3.3.1-alpha, we would exit() in this case immediately.  But
now that we leave tor_main() more conventionally, we need to make
sure we restore things so as not to cause a double free.

Fixes bug 27708; bugfix on 0.3.3.1-alpha.

Bug not in any released Tor.

Bugfix on 5ab2110e; bug not in any
released Tor.

rl1987 authored 6 years ago and Nick Mathewson committed 6 years ago

All node_get_all_orports() does is allocate and return a smartlist
with at most two tor_addr_port_t members that match ORPort's of
node configuration. This is harmful for memory efficiency, as it
allocates the same stuff every time it is called. However,
node_is_a_configured_bridge() does not need to call it, as it
already has all the information to check if there is configured
bridge for a given node.

The new code is arranged in a way that hopefully makes each succeeding
linear search through bridge_list less likely.

rl1987 authored 6 years ago and Nick Mathewson committed 6 years ago

Since this is a refactoring ticket, these tests should pass before
and after the changes are made.

We determine that a cell was dropped by inspecting CIRC_BW fields. If we did
not update the delivered or overhead fields after processing the cell, the
cell was dropped/not processed.

Also emit CIRC_BW events for cases where we decide to close the circuit in
this function, so vanguards can print messages about dropped cells in those
cases, too.

This commit only moves code. No functionality has been changed.

Since this is an "intrusive" test, it only shows up for openssl <1.1

This is a bugfix on 0.3.5.x; bug not in any released Tor.

Bugfix on 0.3.5.x; bugfix not on any released Tor.

David Goulet authored 6 years ago and Nick Mathewson committed 6 years ago

Closes #27547

Signed-off-by: David Goulet <dgoulet@torproject.org>