kind of a losing game to remember to update that comment when
we add another possible family, but hey, maybe it will be a while
until we add one more.

Accept a smaller file and function.
Let router.c grow slightly without warning.
Accept an extra comment line.

Cleanup after 32588.

Comments about 33681.

These tests don't actually trigger bug 32588, but they do increase
the coverage of the auto port config code.

Tests for 32588.

Merge static function declaration deletions from bug32588_042 and
maint-0.4.3 in app/config/config.c.

Merge tests from maint-0.4.1 with new tests from bug32588_035
in test_router.c.

Return early when there is no suitable IPv6 ORPort.
Show the address and port on error, using a convenience function.

Code simplification and refactoring.

Cleanup after 32588.

When IPv6 ORPorts are set to "auto", tor relays and bridges would
advertise an incorrect port in their descriptor.

This may be a low-severity memory safety issue, because the published
port number may be derived from uninitialised or out-of-bounds memory
reads.

Fixes bug 32588; bugfix on 0.2.3.9-alpha.

Due to improved function comments.

Fixes part of bug 33674; not in any released version of tor.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

And document how some functions set their output arguments.

Fixes bug 33674; bugfix on 0.4.3.1-alpha.

Previously we just ignored this option, which would leave it unset,
and cause an assertion failure later on when running with the User
option.

Fixes bug 33668; bugfix on 0.4.3.1-alpha.

Don't take the practracker disable changes from 0.4.3.

Disable our coding standards best practices tracker in our git hooks.

0.4.3 branches only.

Closes ticket 33678.

Obviously correct changes to already-reviewed code.