Due to improved function comments.

Fixes part of bug 33674; not in any released version of tor.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

And document how some functions set their output arguments.

Fixes bug 33674; bugfix on 0.4.3.1-alpha.

Previously we just ignored this option, which would leave it unset,
and cause an assertion failure later on when running with the User
option.

Fixes bug 33668; bugfix on 0.4.3.1-alpha.

Don't take the practracker disable changes from 0.4.3.

Disable our coding standards best practices tracker in our git hooks.

0.4.3 branches only.

Closes ticket 33678.

Obviously correct changes to already-reviewed code.

For example, "TOR_SKIP_TESTCASES=crypto/.. ./src/test/test" will run
the tests and suppress all the "crypto/" tests.  You could get the
same effect by running "./src/test/test :crypto/..", but that can be
harder to arrange from CI.

Part of a fix/workaround for 33643.

(findMergedChanges.pl is the tool to do this.)

Signed-off-by: David Goulet <dgoulet@torproject.org>

Add an inline helper function that indicates if the cached object contains a
decrypted descriptor or not.

The descriptor object is NULL if tor is unable to decrypt it (lacking client
authorization) and some actions need to be done only when we have a decrypted
object.

This improves code semantic.

Fixes #33458

Signed-off-by: David Goulet <dgoulet@torproject.org>

And consistently talk about extra-info document publishing.

Obviously correct documentation changes.

Closes bug 33641; not in any released version of tor.

Accept the current state of the tor codebase, including all the
files and functions that have increased technical debt over the
last few months.

Accepts all the current practracker warnings, so that reviewers
can focus on new warnings.

Closes ticket 33635.

Obviously correct changes to already-reviewed code.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.