Fun fact: PR_Close leaks memory if its socket is not valid.

Everything that might have used it, uses tor_tls_cert_is_valid() instead.

This function was a wrapper around RSA_check_key() in openssl, which
checks for invalid RSA private keys (like those where p or q are
composite, or where d is not the inverse of e, or where n != p*q).
We don't need a function like this in NSS, since unlike OpenSSL, NSS
won't let you import a bogus private key.

I've renamed the function and changed its return type to make it
more reasonable, and added a unit test for trying to read a key
where n != p*q.

The tls_log_errors() function now behaves differently for NSS than
it did for OpenSSL, so we need to tweak it a bit.

This function was supposed to implement a half-duplex mode for our
TLS connections.  However, nothing in Tor actually uses it (besides
some unit tests), and the implementation looks really questionable
to me.  It's probably best to remove it.  We can add a tested one
later if we need one in the future.

This is enough to get a chutney network to bootstrap, though a bunch
of work remains.

juga authored 6 years ago and Nick Mathewson committed 6 years ago

There should be a separate check to update descriptor when start
or end hibernating.