Fixes a bug in our zstd-static code.  Bug not in any released
version of Tor.

"ours" merge to avoid taking 24902 a second time and having to reconcile
all the merge conflicts.

This is necessary because apparently v3 rendezvous cpath hops use
sha3, which I had forgotten.

Bugfix on master; bug not in any released Tor.

These patches were already merged, and so don't need a changes file
in these branches.

"ours" merge to avoid conflicts with the cherry-picked fix for 24898.

Roger Dingledine authored 7 years ago and Nick Mathewson committed 7 years ago

since all it does is produce false positives

this commit should get merged into 0.2.9 and 0.3.0 *and* 0.3.1, even
though the code in the previous commit is already present in 0.3.1. sorry
for the mess.

[Cherry-picked]

Roger Dingledine authored 7 years ago and Nick Mathewson committed 7 years ago

since all it does is produce false positives

this commit should get merged into 0.2.9 and 0.3.0 *and* 0.3.1, even
though the code in the previous commit is already present in 0.3.1. sorry
for the mess.

Roger Dingledine authored 7 years ago and Nick Mathewson committed 7 years ago

This commit takes a piece of commit af8cadf3 and a piece of commit
46fe353f25, with the goal of making channel_is_client() be based on what
sort of connection handshake the other side used, rather than seeing
whether the other side ever sent a create_fast cell to us.

Bug not in any released Tor.

Fixes bug 25276; bugfix not in any released Tor.

Instead, define a maximum size, and enforce it with an assertion.

(When a variable isn't going to be declared extern in the header, we
require that it be static.)

 * FIXES #25271: https://bugs.torproject.org/25271