The alternative has been available since 2007, there's no way to
actually enable the ifdef, and it breaks on well formed but not OpenSSL
style inputs.

Fixes bug 15591; patch from joelanders

Fixes coverity defect CID 1293337, not in any released version of tor.

Yawning Angel authored 10 years ago and Nick Mathewson committed 9 years ago

In theory these should never the triggered as the only caller now
validates the parameters before this routine gets called.

Yawning Angel authored 10 years ago and Nick Mathewson committed 9 years ago

Found by DonnchaC.

Yawning Angel authored 10 years ago and Nick Mathewson committed 9 years ago

Fixes bug 15600; reported by skruffy

George Kadianakis authored 10 years ago and Nick Mathewson committed 10 years ago

(Sending a nak would be pointless.)

See ticket 15515 for discussion.

George Kadianakis authored 10 years ago and Nick Mathewson committed 10 years ago

(Sending a nak would be pointless.)

See ticket 15515 for discussion.

We no longer base our opinion on whether someone is a directory solely
on the routerstatus we might have for that relay, but also on a
routerinfo. Remove logic in test checking that. This broke unit tests in
05f73366.

Reported by toralf on #tor-dev, thanks!