At this commit, 93.9% of line coverage and 95.5% of function coverage.

Closes #32196

Signed-off-by: David Goulet <dgoulet@torproject.org>

Facilitate testing.

Part of #32196.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Signed-off-by: David Goulet <dgoulet@torproject.org>

Fake circuits are created everywhere in the unit tests. This is an attempt at
centralizing a "fake circuit creation" API like fakechans.c does for channel.

This commit introduces fakecircs.c and changes test_relay.c and
test_circpadding.c which were using roughly the same code.

This will allow easier OR circuit creation for the future tests in
test_circuitmux.c

Signed-off-by: David Goulet <dgoulet@torproject.org>

Signed-off-by: David Goulet <dgoulet@torproject.org>

This also rename a function to improve code clarity.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Also remove a scheduler_init() from a test and MOCK the appropriate function
so the test can pass.

This is done in order to minimize initialization functions in the unit test
and try to only go through the testcase setup object.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Step needed in order to access members of the object for unit tests.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Signed-off-by: David Goulet <dgoulet@torproject.org>

Bugfix on 31919; not in any released version of tor.

(Or any dot files.)

Obviously correct changes to already-reviewed code.

Some versions of shellcheck do not detect this error.

Bugfix on 31919; not in any released version of tor.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

These declarations also turned up a doxygen warning for
proto_socks.c; I fixed that too.

If a file doesn't use the file command (either \file or @file),
Doxygen won't try to process it.

These declarations also turned up a doxygen warning for
crypto_ope.c; I fixed that too.

This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        confparse.h confmgt.h \
        confparse.c confmgt.c \
        CONFPARSE_PRIVATE CONFMGT_PRIVATE \
        TOR_CONFPARSE_H TOR_CONFMGT_H

This will break compilation until includes etc are fixed.

Since these are needed by every module that is _configurable_, they
belong in lib/conf, not lib/confmgt.

In the unit tests.

Fixes a regression to bug 31334; bug not in any released version of tor.

Obviously correct fix to rename_c_identifier.py.

Bugfix on 32237; not in any released version of tor.

Based on 8-space tabs, the git/less default.

Cleanup after 31919.

And print the spatch version and build details

Part of 31919.