Fixes 14280 bugfix on 1053af0b in 0.2.4.7-alpha.

Conflicts:
	src/or/connection_edge.c

Also, do a little light refactoring to move some variable declarations
around and make a few things const

Also fix an obnoxious bug on checking for the DONE stream end reason.
It's not a flag; it's a possible value or a variable that needs to be
masked.

Conflicts:
	src/or/config.c

Roger Dingledine authored 10 years ago and Nick Mathewson committed 10 years ago

(Patch from arma, commit message from nick.)

Closes #14222.

Roger Dingledine authored 10 years ago and Nick Mathewson committed 10 years ago

This fixes a bug where we'd fetch different replicas of the same
descriptor for a down hidden service over and over, until we got lucky
and fetched the same replica twice in a row.

Fixes bug 14219; bugfix on 0.2.0.10-alpha.

(Patch from Roger; commit message and changes file by Nick.)

Conflicts:
	src/or/directory.c

We've started to hit the limit here.  We introduced the limit in
0.1.2.5-alpha.  This fixes bug 14261, but we should have a smarter way
to not actually do the behavior this permits.  See #14267 for a ticket
about fixing that.

Spotted by asn.  #14259.  Bugfix on 368eb6a9 in 0.2.0.1-alpha.

Conflicts:
	src/test/test_relaycell.c
	src/test/test_util.c

This incidentally makes unix SocksSocket support all the same options
as SocksPort.

This patch breaks 'SocksSocket 0'; next will restore it.

Resolves 14254.

Conflicts:
	src/or/connection.c
	src/or/or.h
	src/or/relay.c

Also rename some options for uniformity, and apply this script:

@@
entry_connection_t *conn;
@@
 conn->
+entry_cfg.
\(
 isolation_flags
\|
 session_group
\|
 socks_prefer_no_auth
\|
 ipv4_traffic
\|
 ipv6_traffic
\|
 prefer_ipv6
\|
 cache_ipv4_answers
\|
 cache_ipv6_answers
\|
 use_cached_ipv4_answers
\|
 use_cached_ipv6_answers
\|
 prefer_ipv6_virtaddr
\)

Also, revise the code using these options with this cocci script:

@@
listener_connection_t *conn;
@@
 conn->
+entry_cfg.
\(
 isolation_flags
\|
 session_group
\|
 socks_prefer_no_auth
\|
 ipv4_traffic
\|
 ipv6_traffic
\|
 prefer_ipv6
\|
 cache_ipv4_answers
\|
 cache_ipv6_answers
\|
 use_cached_ipv4_answers
\|
 use_cached_ipv6_answers
\|
 prefer_ipv6_virtaddr
\)

Also, apply this cocci script to transform accesses. (Plus manual
migration for accesses inside smartlist_foreach loops.)

@@

port_cfg_t *cfgx;
@@
 cfgx->
+server_cfg.
\(
 no_advertise
\|
 no_listen
\|
 all_addrs
\|
 bind_ipv4_only
\|
 bind_ipv6_only
\)

@@

port_cfg_t *cfgx;
@@
 cfgx->
+entry_cfg.
\(
 isolation_flags
\|
 session_group
\|
 socks_prefer_no_auth
\|
 ipv4_traffic
\|
 ipv6_traffic
\|
 prefer_ipv6
\|
 cache_ipv4_answers
\|
 cache_ipv6_answers
\|
 use_cached_ipv4_answers
\|
 use_cached_ipv6_answers
\|
 prefer_ipv6_virtaddr
\)

Backports some commits from tor master.

Closes 14207; bugfix on 0.2.6.2-alpha.

George Kadianakis authored 10 years ago and Nick Mathewson committed 10 years ago

Do this in even more places to try to fix the build.

Fixes 14215; bugfix on 0.2.6.2-alpha.  Reported by "cypherpunks".

Add comments in rendclient.c noting that certain functions involved in handling ended HS connection attempts must be idempotent

This helps avoid undefined behavior from casting big double values to
int64_t. Fixes #14090.