teor authored 5 years ago and Nick Mathewson committed 5 years ago

And document how some functions set their output arguments.

Fixes bug 33674; bugfix on 0.4.3.1-alpha.

Previously we just ignored this option, which would leave it unset,
and cause an assertion failure later on when running with the User
option.

Fixes bug 33668; bugfix on 0.4.3.1-alpha.

Disable our coding standards best practices tracker in our git hooks.

0.4.3 branches only.

Closes ticket 33678.

Obviously correct changes to already-reviewed code.

For example, "TOR_SKIP_TESTCASES=crypto/.. ./src/test/test" will run
the tests and suppress all the "crypto/" tests.  You could get the
same effect by running "./src/test/test :crypto/..", but that can be
harder to arrange from CI.

Part of a fix/workaround for 33643.

And consistently talk about extra-info document publishing.

Obviously correct documentation changes.

Obviously correct changes to already-reviewed code.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

George Kadianakis authored 5 years ago and Nick Mathewson committed 5 years ago

This unittest currently fails on purpose (to demonstrate the bug) but it will
stop failing after the next commit (the bugfix).

George Kadianakis authored 5 years ago and Nick Mathewson committed 5 years ago

Given that ed25519 public key validity checks are usually not needed
and (so far) they are only necessary for onion addesses in the Tor
protocol, we decided to fix this specific bug instance without
modifying the rest of the codebase (see below for other fix
approaches).

In our minimal fix we check that the pubkey in
hs_service_add_ephemeral() is valid and error out otherwise.