metrics: Add new relay metrics to MetricsPort

Closes #40816

See merge request !793

Signed-off-by: David Goulet <dgoulet@torproject.org>

juga authored Nov 18, 2023 and David Goulet committed Jan 30, 2024

Allow "node_id" KeyValue without the dollar sign at the start of the
hexdigit in the BandwidthFiles, in order to easier database queries
combining Tor documents in which the relays fingerprint doesn't
include it.
Bugfix on all supported versions of Tor.

Closes #40891

This commit adds the total number of DROP cell seen, the total number of
DESTROY cell received and the total number of protocol violation that lead to a
circuit close.

Closes #40816



Signed-off-by: David Goulet <dgoulet@torproject.org>

Use raw strings for regexs containing escapes

See merge request !790

In Python 3.12, these invalid escape sequences emit SyntaxWarnings, and will
emit SyntaxErrors in a future release.

Found using: grep '[^r]["'\''].*\\[^rn\\x0t"]' $(grep -rl '^#!.*python')

We strongly suspect that bug 40897 was caused by a custom Tor client that
tried to use more than the default number of conflux circuits, for either
performance or traffic analysis defense gains, or both.

This entity hit a safety check on the exit side, which caused a UAF. Our
"belt and suspenders" snapped off, and hit us in the face... again...

Since there are good reasons to try more than 2 conflux legs, and research has
found some traffic analysis benefits with as many as 5, we're going to raise
and parameterize this limit as a form of bug bounty for finding this UAF, so
that this entity can try out a little more confluxing.

This should also make it easier for researchers to try things like gathering
traces with larger amounts of confluxing than normal, to measure real-world
traffic analysis impacts of conflux.

Shine on, you yoloing anonymous diamond. Let us know if you find out anything
interesting!

Similar double-frees would be caught earlier by these, so long as the pointers
remain nulled out.

Fix bridge exit warn

Closes #40884

See merge request !783

add sanity check in tor_memmem

Closes #40854

See merge request !785

don't warn for empty RecommendedServerVersion

Closes #40888

See merge request !787

juga authored Nov 18, 2023 and David Goulet committed Nov 21, 2023

Allow "node_id" KeyValue without the dollar sign at the start of the
hexdigit in the BandwidthFiles, in order to easier database queries
combining Tor documents in which the relays fingerprint doesn't
include it.
Bugfix on all supported versions of Tor.

Closes #40891

forward-port the 0.4.8.x change stanzas

See merge request !784

it's believed most libc already have those, but just in case, it can't
hurt

somehow our release process is not moving these into git main