Audit DisableNetwork, we_are_hibernating usage
I think a lot of our DisableNetwork checks should instead check net_is_disabled, since so much of what we're doing turning off when the network is disabled is also something we're trying to turn off when we're hibernating.
And probably some of our DisableNetwork checks should call should_delay_dir_fetches or something similar, if they're related to fetching non-bridge-descriptor directory stuff.
Possibly there should be a better designed hierarchy here.
Possibly, most of the fixes here should wait for 0.2.6, since this code is tricky.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Nick Mathewson changed milestone to %Tor: 0.3.3.x-final in legacy/trac
changed milestone to %Tor: 0.3.3.x-final in legacy/trac
- Nick Mathewson added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::nickm in Legacy / Trac priority::medium in Legacy / Trac quiet-mode in Legacy / Trac resolution::implemented in Legacy / Trac review-group-24 in Legacy / Trac severity::normal in Legacy / Trac sponsor8-maybe in Legacy / Trac sponsor::8-can in Legacy / Trac status::closed in Legacy / Trac technical-debt in Legacy / Trac tor-client in Legacy / Trac type::defect in Legacy / Trac labels
added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::nickm in Legacy / Trac priority::medium in Legacy / Trac quiet-mode in Legacy / Trac resolution::implemented in Legacy / Trac review-group-24 in Legacy / Trac severity::normal in Legacy / Trac sponsor8-maybe in Legacy / Trac sponsor::8-can in Legacy / Trac status::closed in Legacy / Trac technical-debt in Legacy / Trac tor-client in Legacy / Trac type::defect in Legacy / Trac labels
- Author Owner
Trac:
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.6.x-final - Author Owner
Trac:
Keywords: tor-client deleted, tor-client 026-triaged-1 added - Author Owner
Trac:
Milestone: Tor: 0.2.6.x-final to Tor: 0.2.??? - Author Owner
Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.
Trac:
Milestone: Tor: 0.3.??? to Tor: unspecified
Keywords: tor-client 026-triaged-1 deleted, tor-client, 026-triaged-1, tor-03-unspecified-201612 added - Author Owner
Remove an old triaging keyword.
Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added - Author Owner
Trac:
Keywords: 026-triaged-1 deleted, N/A added - Author Owner
Trac:
Sponsor: N/A to N/A
Keywords: tor-client deleted, tor-client technical-debt quiet-mode sponsor8-maybe added
Reviewer: N/A to N/A
Severity: N/A to Normal - Author Owner
Trac:
Sponsor: N/A to Sponsor8-can
Milestone: Tor: unspecified to Tor: 0.3.2.x-final - Author Owner
Trac:
Owner: N/A to nickm
Status: new to accepted - Author Owner
See my branch
ticket12062
. Delaying to 0.3.3 since this is tricky to test.Trac:
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.3.x-final
Status: accepted to needs_review - Author Owner
(None of the bugs found here seem terrible, which is good)
- Author Owner
review-group-24 is now open.
Trac:
Keywords: tor-client technical-debt quiet-mode sponsor8-maybe deleted, technical-debt, sponsor8-maybe, tor-client, review-group-24, quiet-mode added - Owner
I think the code added to
should_delay_dir_fetches()
is missing a "return 1".The rest lgtm;
Trac:
Status: needs_review to needs_revision - Author Owner
added a fixup commit; squashed as ticket12062_squashed
- Author Owner
Trac:
Status: needs_revision to merge_ready - Author Owner
merging to master. Thanks!
- Author Owner
(No backport planned -- this code is subtle and hard to test, and the bugs here are minor.)
Trac:
Status: merge_ready to closed
Resolution: N/A to implemented - Trac closed
closed
- Trac moved from legacy/trac#12062 (moved)
moved from legacy/trac#12062 (moved)
- Gaba added Technical Debt label and removed 1 deleted label
added Technical Debt label and removed 1 deleted label
- Roger Dingledine mentioned in issue #40605
mentioned in issue #40605