Skip to main content
Sign in
Snippets Groups Projects

compute_weighted_bandwidths() broken for dirauths

  • View options
  • Closed created by George Kadianakis
    Closed compute_weighted_bandwidths() broken for dirauths
    • View options
  • I suspect that compute_weighted_bandwidths() is broken for dirauths. All the booleans is_guard, is_exit, etc. are populated according to the node_t.

    However, nodelist_set_consensus() which creates those node_ts does not fill in those fields if we are a dirauth:

        if (!authdir) {
          node->is_valid = rs->is_valid;
          node->is_running = rs->is_flagged_running;
          node->is_fast = rs->is_fast;
          node->is_stable = rs->is_stable;
          node->is_possible_guard = rs->is_possible_guard;
    ...

    I don't think this has any big implications, but dirauths are probably doing the wrong path selection. Maybe it's more important if someone is doing bwauth measurements using the dirauth code (if that even makes sense).

    Attributes

    Assignees

    None

    Labels

    Milestone

    None

    Dates

    Start: None

    Due: None

    Time tracking

    No estimate or time spent
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first