Increase torgzip coverage as high as possible

We've actually had bugs in this one that caused needless bandwidth wastage. (eg legacy/trac#11824 (moved) and legacy/trac#11787 (moved).) Let's see if there are any more!

x/torgzip.c.gcov 88 136 60.71

changed milestone to %Tor: 0.2.9.x-final in legacy/trac

added 028-triage in Legacy / Trac TorCoreTeam201606 in Legacy / Trac actualpoints::.2 in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.2.9.x-final in Legacy / Trac owner::nickm in Legacy / Trac parent::17289 in Legacy / Trac points::1 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac review-group-3 in Legacy / Trac reviewer::andrea in Legacy / Trac severity::normal in Legacy / Trac sponsor::S-can in Legacy / Trac status::closed in Legacy / Trac testing in Legacy / Trac tor-tests-coverage in Legacy / Trac tor-tests-unit in Legacy / Trac type::enhancement in Legacy / Trac labels

Trac:
Milestone: N/A to Tor: 0.2.8.x-final

Trac:
Keywords: N/A deleted, 028-triage added

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

Trac:
Sponsor: N/A to SponsorS
Keywords: SponsorS deleted, N/A added

Trac:
Points: N/A to small

Throw most 0.2.8 "NEW" tickets into 0.2.9. I expect that many of them will subsequently get triaged out.

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

Trac:
Sponsor: SponsorS to SponsorS-can

Trac:
Keywords: N/A deleted, tor-tests-coverage, tor-tests-unit added

Trac:
Points: small to 1

Trac:
Parent: legacy/trac#16791 (moved) to legacy/trac#17289 (moved)
Milestone: Tor: 0.2.9.x-final to N/A

I've made a start here with my branch zlib_coverage. It focuses on stuff that's not covered by unit or integration tests. It gets coverage from "make check" on torgzip.c up over 80%

Trac:
Status: new to accepted
Severity: N/A to Normal
Reviewer: N/A to nick
Owner: N/A to nickm

Trac:
Actualpoints: N/A to .2
Status: accepted to needs_review
Keywords: tor-tests-unit deleted, tor-tests-unit TorCoreTeam201606 added
Milestone: N/A to Tor: 0.2.9.x-final

Commit cdb8f57a3138f6f9a59183094e89ee72df43d356

+#if defined ZLIB_VERNUM && ZLIB_VERNUM < 0x1200
+#define "We require zlib version 1.2 or later."
+#endif

Shouldn't this be #error? And if so, wouldn't it be better to test this when setting up the build environment (aka ./configure)?

-  if (is_gzip_supported()) {
+
+  if (1) {

Why not simply remove the if statement?

Shouldn't this be #error? yup, #error.

We could check it in configure (if somebody wants to write a patch) but personally I don't expect that there are enough zlib 1.1 users remaining for this to be worth much time.

Why not simply remove the if statement?

IMO best to do that as a separate patch, so that the diff doesn't get spuriously large.

Move some tickets into review-group-3: they are in 0.2.9, and they are needs_review.

Trac:
Keywords: tor-tests-unit TorCoreTeam201606 deleted, tor-tests-unit, TorCoreTeam201606, review-group-3 added

Trac:
Reviewer: nick to N/A

Trac:
Reviewer: N/A to andrea

If you're keen to try gitlab for reviewing this, I've made a merge request there as https://gitlab.com/nickm_tor/tor/merge_requests/2 .

See comments on gitlab merge request

Trac:
Status: needs_review to needs_revision

fixed and squashed and applied. Thanks!

Trac:
Type: defect to enhancement
Status: needs_revision to closed
Resolution: N/A to implemented

closed

changed time estimate to 8h

added 1h 36m of time spent

moved from legacy/trac#16801 (moved)

added Feature label and removed 1 deleted label

added Tests label and removed 1 deleted label