Mark TestingTorNetwork PREDICT_UNLIKELY
I'd like to see every instance of:
if (options->TestingTorNetwork) {
(or similarly, get_options()->
)
transformed to:
if (PREDICT_UNLIKELY(options->TestingTorNetwork)) {
This should give us a slight performance boost in relays and authorities, at the cost of a slight slowdown due to missed branch predictions in test networks.
This would be best done using a coccinelle, perl, or sed script.