Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 311
    • Issues 311
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #16849
Closed
Open
Created Aug 18, 2015 by teor@teor

clear_status_flags_on_sybil might want to clear more flags

clear_status_flags_on_sybil contains a comment saying "it's easy to add a new flag but forget to add it to this clause."

It looks like we may have forgot the following flags:

  • is_hs_dir
  • version_known?
  • version_supports_extend2_cells?
  • has_bandwidth
  • has_exitsummary?
  • bw_is_unmeasured? (set to 1?)
  • bandwidth_kb
  • has_guardfraction
  • guardfraction_percentage

To deal with the root cause, should we instead zero out the entire routerstatus_t, then copy the fields we need back in? (This would zero new fields on sybils by default.)

We could also implement a unit test for clear_status_flags_on_sybil that checks that certain (important?) flags are cleared, or that all flags are cleared (?).

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking