Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #1802
Closed
Open
Created Aug 05, 2010 by cjb@cjb

ControlPort GETCONF does not recognize command aliases

Because commands passed to GETCONF are not looked-up in the aliases table with expand_abbrev(), we reject GETCONF requests for options that would be valid (though deprecated) if they were used in a torrc.

For example, GETCONF AllowInvalidNodes works whereas GETCONF AllowUnverifiedNodes fails. AllowUnverifiedNodes is a deprecated alias for AllowInvalidNodes.

I propose fixing this by having handle_control_getconf() first call expand_abbrev() on the option it's going to look up. I'll attach a patch that does that for review.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking