HS Descriptors should only contain UTF-8

In legacy/trac#18938 (moved), we discovered some relays publishing platform lines or extrainfo documents with non-ASCII characters.

This seems to occur due to memory corruption.

So let's make sure that a non-ASCII UTF-8 check is done on:

• hidden services: unencrypted or encrypted descriptor
• HSDirs: encrypted descriptor
• clients: unencrypted or encrypted descriptor

See https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n45

This might require a spec change - it's likely implicit in the spec already.

For completeness, the set of printable ASCII characters is defined in dir-spec.txt ... Where I assume "printing ASCII" means "space to tilde", but we should also clarify that in the torspec.

changed milestone to %Tor: unspecified in legacy/trac

added component::core tor/tor in Legacy / Trac milestone::Tor: unspecified in Legacy / Trac parent::24033 in Legacy / Trac priority::medium in Legacy / Trac prop224 in Legacy / Trac prop285 in Legacy / Trac severity::normal in Legacy / Trac sponsor::R-can in Legacy / Trac status::new in Legacy / Trac tor-hs in Legacy / Trac type::enhancement in Legacy / Trac labels

Trac:
Summary: Descriptors should only contain printable ASCII to HS Descriptors should only contain printable ASCII

I'm moving this one to 029-proposed because legacy/trac#17238 (moved) is planned for 029 (HOPEFULLY). This is a check in the current code under development for which I think is a good idea.

Although, I would see that being implemented in routerparse.c with some flag asking for non-ASCII check and not being an HS specific thing so if legacy/trac#18938 (moved) gets in 029, we have this for free else we can differ it until it's supported upstream.

Trac:
Keywords: 030-proposed deleted, 029-proposed added

Let's not block on HSDir support (legacy/trac#17238 (moved)) for this. I see this as an improvement to the implementation not a dependency.

Trac:
Sponsor: N/A to SponsorR-can
Parent: legacy/trac#17238 (moved) to N/A

Trac:
Keywords: N/A deleted, 029-nickm-says-no added

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Move the 0.3.??? prop224 tickets to the 031 milestone.

Trac:
Milestone: Tor: 0.3.??? to Tor: 0.3.1.x-final

Deferring this; probably doesn't actually matter too much?

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: unspecified

Prioritize prop224 tickets for 031 milestone. They are all "Enhancement".

Trac:
Priority: Medium to Very High

Trac:
Priority: Very High to Medium

Trac:
Keywords: 029-nickm-says-no deleted, N/A added

Trac:
Keywords: 029-proposed deleted, N/A added

Trac:
Parent: N/A to legacy/trac#24033 (moved)

Trac:
Owner: N/A to neel
Status: new to assigned

Trac:
Cc: N/A to neel@neelc.org

See https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n33

Oh, and https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n33

Trac:
Summary: HS Descriptors should only contain printable ASCII to HS Descriptors should only contain UTF-8
Keywords: N/A deleted, prop285 added
Description: In legacy/trac#18938 (moved), we discovered some relays publishing platform lines or extrainfo documents with non-ASCII characters.

This seems to occur due to memory corruption.

So let's make sure that a non-ASCII check is done on:

• hidden services: unencrypted or encrypted descriptor
• HSDirs: encrypted descriptor
• clients: unencrypted or encrypted descriptor

This might require a spec change - it's likely implicit in the spec already.

For completeness, the set of printable ASCII characters is defined in dir-spec.txt as:

    NL = The ascii LF character (hex value 0x0a).
    KeywordChar ::= 'A' ... 'Z' | 'a' ... 'z' | '0' ... '9' | '-'
    ArgumentChar ::= any printing ASCII character except NL.
    WS = (SP | TAB)+

Where I assume "printing ASCII" means "space to tilde", but we should also clarify that in the torspec.

to

In legacy/trac#18938 (moved), we discovered some relays publishing platform lines or extrainfo documents with non-ASCII characters.

This seems to occur due to memory corruption.

So let's make sure that a non-ASCII UTF-8 check is done on:

• hidden services: unencrypted or encrypted descriptor
• HSDirs: encrypted descriptor
• clients: unencrypted or encrypted descriptor

See https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt#n45

This might require a spec change - it's likely implicit in the spec already.

For completeness, the set of printable ASCII characters is defined in dir-spec.txt ... Where I assume "printing ASCII" means "space to tilde", but we should also clarify that in the torspec.

Trac:
Cc: neel@neelc.org to N/A
Owner: neel to N/A

Trac:
Status: assigned to new

moved from legacy/trac#19647 (moved)

added Feature label and removed 1 deleted label

added 1 deleted label and removed 1 deleted label

Closing in favor of proposal 285.

closed