Keep the interface address order returned by the OS

legacy/trac#17027 (moved) unintentionally reorders interface addresses, by using SMARTLIST_DEL_CURRENT() in get_interface_address6_list() to delete unsuitable addresses, rather than SMARTLIST_DEL_CURRENT_KEEPORDER().

This makes address selection unstable, because it depends on not only the exact order in which the OS returns addresses, but the exact number of unsuitable addresses as well.

changed milestone to %Tor: 0.2.9.x-final in legacy/trac

added 029-proposed in Legacy / Trac component::core tor/tor in Legacy / Trac easy in Legacy / Trac intro in Legacy / Trac milestone::Tor: 0.2.9.x-final in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::tor 0.2.7.1-alpha in Legacy / Trac labels

I can take a patch for this in 029 if somebody writes one on time.

Trac:
Keywords: 029-proposed deleted, 029-proposed easy intro added

This issue was reported by René Mayrhofer.

(Hmm, do we do unicode in our changelogs? Otherwise it's going to be hard to credit René without a misspelling.)

UTF-8 unicode is fine.

Trac:
0001-Avoid-reordering-IPv6-interface-addresses.patch

Here is a patch that I believe should work, but I would appreciate some additional testing.

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.2.9.x-final
Status: new to needs_review

This looks fine to merge, it needs a changes file that says something like:

Stop reordering IP addresses returned by the OS.
This makes is more likely that Tor will guess the same relay IP address every time.
Fixes issue 20163; bugfix on 0.2.7.1-alpha, ticket 17027.
Reported by René Mayrhofer, patch by "cypherpunks".

Trac:
Status: needs_review to merge_ready

merging, with copy-pasted changes file.

(also, thanks!)

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 48m

mentioned in issue legacy/trac#20164 (moved)

moved from legacy/trac#20163 (moved)

added Bug First Contribution labels and removed 1 deleted label

removed 1 deleted label