prop224: Rendezvous circuit e2e crypto

In order to establish an end-to-end crypto channel on a rendezvous circuit, we need a new API that setups the crypt_path_t object on the circuit from the key material computed between the client and service. This API has to be for both service and client side.

Because the service implementation in legacy/trac#20657 (moved) is being done before client, setting parent ID to that ticket.

changed milestone to %Tor: 0.3.2.x-final in legacy/trac

added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.2.x-final in Legacy / Trac owner::asn in Legacy / Trac parent::21888 in Legacy / Trac points::9 in Legacy / Trac priority::very high in Legacy / Trac prop224 in Legacy / Trac resolution::implemented in Legacy / Trac review-group-19 in Legacy / Trac reviewer::nickm in Legacy / Trac severity::normal in Legacy / Trac sponsor::R-must in Legacy / Trac status::closed in Legacy / Trac tor-hs in Legacy / Trac type::enhancement in Legacy / Trac labels

If we can make it happen before 032, great, else no biggy. Changing parent ticket to the "prop224 groundwork" ticket since this is needed by legacy/trac#20657 (moved) and can be merged safely upstream without affecting tor.

Trac:
Parent: legacy/trac#20657 (moved) to legacy/trac#21888 (moved)
Owner: N/A to asn
Status: new to assigned

Trac:
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.1.x-final

OK pushed branch bug21859 to my repo with initial code for this ticket.

Most of the commits are refactoring stuff and preparing for not-done-before unittests. Commit 32ffaedf9 actually does most of the work.

Please find gitlab merge request here: https://gitlab.com/asn/tor/merge_requests/14/diffs

Moving this to 0.3.2 milestone since it requires all the hs_ident stuff that are gonna be merged in 0.3.2 . If we wanted to merge stuff earlier, we could split the branch into a 0.3.1 branch that only does legacy stuff, and then merge the 0.3.2 stuff later.

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: 0.3.2.x-final
Status: assigned to needs_review

Trac:
Points: 3 to 9

I commented. Nothing major, mostly naming and comments. Good stuff!!!

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to needs_revision

OK pushed branch bug21859_v2, which includes all of David's review fixes.

Putting ticket in neutral state. Not sure if this should be in needs_review as it's 0.3.2 material and part of legacy/trac#21888 (moved).

Trac:
Status: needs_revision to assigned

This is a big piece of groundwork for prop224 service implementation legacy/trac#20657 (moved).

This branch contains basically two things. It adds hidden service identifiers (hs_ident.{c|h}) which is the new and improved rend_data concept. Then, it introduces an API/ABI for the e2e encryption of client<->service.

Tor branch: ticket21859_032_01 Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/29

The prop224 train has started for 032! :)

Trac:
Status: assigned to needs_review
Reviewer: dgoulet to nickm

Trac:
Keywords: N/A deleted, review-group-19 added

Review done; I didn't find any terrible bugs, but I think there are some style and safety issues we should fix before we move on.

Trac:
Status: needs_review to needs_revision

Everything has been addressed/commented. Let's go back in needs_review.

Trac:
Status: needs_revision to needs_review

Squashed as ticket21859_032_01_squashed, then small changes added. Then merged. Hooray!

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

closed

changed time estimate to 72h

moved from legacy/trac#21859 (moved)

added Feature + 1 deleted label and removed 1 deleted label

added 1 deleted label and removed 1 deleted label