Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 316
    • Issues 316
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #23061
Closed
Open
Created Jul 31, 2017 by teor@teor

crypto_rand_double() should produce all possible outputs on platforms with 32-bit int

On 32-bit platforms, crypto_rand_double() only produces 1 in every 2 million possible values between 0 and 1.

This happens because:

  • crypto_rand_double() divides a random unsigned int by UINT_MAX
  • an unsigned int on 32-bit platforms is 32 bits
  • the mantissa on a double is 53 bits

So crypto_rand_double() doesn't fill the lower 21 bits with random values.

This makes the rep_hist_format_hs_stats() noise more predictable on 32-bit platforms.

This fix shouldn't affect the unit tests, because they pass on 64-bit.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking