Stop closing channels out from under OR connections in hibernate_go_dormant()

This allows dormant connections to flush then close normally. Bugfix on legacy/trac#7267 (moved) in 0.2.4.7-alpha.

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

added actualpoints::0.2 in Legacy / Trac component::core tor/tor in Legacy / Trac hibernate in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::teor in Legacy / Trac points::0.2 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac review-group-24 in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tor-client in Legacy / Trac tor-relay in Legacy / Trac type::defect in Legacy / Trac version::tor 0.2.4.7-alpha in Legacy / Trac labels

Does the "this" and the ".2 points" mean you've got a patch?

Please see my branch bug7267, which uses the documented function for closing OR connections.

Trac:
Status: new to needs_review

Trac:
Owner: N/A to teor
Description: This allows dormant connections to flush then close normally. Bugfix on 7267 in 0.2.4.7-alpha.

to

This allows dormant connections to flush then close normally. Bugfix on legacy/trac#7267 (moved) in 0.2.4.7-alpha.
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

review-group-24 is now open.

Trac:
Keywords: N/A deleted, review-group-24 added

Do we want to be setting the hold_open_until_flushed flag here, really? I don't think we did that before...

(Otherwise, looks plausible. I assume this is reasonably chutney-tested?)

Trac:
Status: needs_review to needs_revision

Yes, I've used this patch repeatedly in chutney, because it gives better behaviour when counting circuits in experimental privcount.

I added a fixup that sets the hold_open_until_flushed flag to 0.

Trac:
Status: needs_revision to needs_review

Trac:
Status: needs_review to merge_ready

Squashed as bug23571_033_squashed and merged to master. Thanks!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 1h 36m

added 1h 36m of time spent

mentioned in issue legacy/trac#23573 (moved)

moved from legacy/trac#23571 (moved)

added Bug label and removed 1 deleted label

added Client Relay labels and removed 1 deleted label