There are places in protover.rs where, if we were to change our C code without a corresponding change, we could break things. We should mark the C and the Rust code in all of those places.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Child items 0
Show closed items
No child items are currently assigned. Use child items to break down this issue into smaller parts.
Linked items 0
Link issues together to show that they're related.
Learn more.
See git@github.com:chelseakomlo/tor_patches.git, branch 24032-cargo-rust-sync. I can make a PR in oniongit if that makes review easier; these are all documentation changes.
I annotated only where data needs to stay in sync (such as enums and constants). If we change actual logic/behavior in src/or/protover, src/rust/protover will definitely need to change as well. I can put a comment in src/rust/protover/lib.rs to say that the overall module needs to track the C implementation if that would be helpful.
Merged! I've also added corresponding comments in the C code, and a suggestion to do it in both places in the future. (Rationale: if the dependency is undocumented at either location, then it's likelier that somebody will edit that location without noticing the dependency.)
Trac: Resolution: N/Ato implemented Status: needs_review to closed