Make set_routerstatus_from_routerinfo() set IPv6 unspecified addresses

set_routerstatus_from_routerinfo() currently sets ipv6_orport to all zeroes. But it should be set to the unspecified IPv6 address.

This is unlikely to cause any bugs in previous Tor versions, but we should fix this for correctness.

This is a bug on commit 6d99c51f in 0.2.4.1-alpha.

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

added actualpoints::0.1 in Legacy / Trac code-correctness in Legacy / Trac component::core tor/tor in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::teor in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac review-group-27 in Legacy / Trac reviewer::dgoulet in Legacy / Trac severity::normal in Legacy / Trac sponsor::V-can in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::tor 0.2.4.1-alpha in Legacy / Trac labels

isn't the unspecified address ::/0 (or all bits equal to zero)?

(Un-parenting, because this doesn't depend on any of the rest of legacy/trac#20916 (moved).)

Replying to Sebastian:

isn't the unspecified address ::/0 (or all bits equal to zero)?

Yes, the unspecified IPv6 address has all bits equal to zero.

But struct tor_addr_t also has a sa_family_t family; member. In this case, it's more correct to have it set to AF_INET6 rather than AF_UNSPEC:

• it makes for better formatting when we print out the address, and
• if ipv6_addr is always AF_INET6, it makes it less likely we will introduce bugs.

The initialisation of ipv6_orport is completely redundant, but it's nice to do it explicitly so it's consistent with the if case.

Please see my branch bug24488 on github.

Trac:
Status: new to needs_review
Parent: legacy/trac#20916 (moved) to N/A

Trac:
Keywords: N/A deleted, review-group-27 added

setting owner

Trac:
Status: needs_review to assigned
Owner: N/A to teor

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to dgoulet

lgtm;

Trac:
Status: needs_review to merge_ready

lgtm too; merged to master

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

moved from legacy/trac#24488 (moved)

added Bug label and removed 1 deleted label

added IPv6 label and removed 1 deleted label