Use ping ::1 on Linux when ping6 ::1 fails

Turns out that some Linuxes don't have ping6, but ping ::1 works just fine.

This is a one-line change in Makefile.am

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

added component::core tor/tor in Legacy / Trac easy in Legacy / Trac intro in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac points::0.2 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::teor in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac test in Legacy / Trac type::defect in Legacy / Trac version::tor 0.2.9.3-alpha in Legacy / Trac labels

Done! Check my github branch bug24677.

PD: I have also added failure and success message :)

Trac:
Status: new to needs_review

looks plausible to me; do you like it, teor?

Trac:
Reviewer: N/A to teor

Seems fine to me, I updated the comments to match the new code in my branch bug24677. (Aren't standards great?)

This passes make test-network-all on macOS (BSD) and Ubuntu (ping6 Linux), so the patch preserves existing behaviour.

Trac:
Status: needs_review to merge_ready

The changes file syntax for bugs is slightly different, it references the tor version that the bug was introduced in. Please update the changes file, and flip the ticket back to merge_ready.

Trac:
Status: merge_ready to needs_revision

Oh, don't forget my extra commit with the comment changes. My branches are at https://github.com/teor2345/tor.git

Also, feel free to credit yourself in the changes file using "Patch by (preferred name or handle)".

I wanted to add your commit on my branch but I wasn't able to. So I make the comment changes on my commit if you can give me a patch file of the commit I will add it :-).

All changes are in my github branch bug24677

Trac:
Status: needs_revision to merge_ready

Replying to ffmancera:

I wanted to add your commit on my branch but I wasn't able to.

It's ok, I don't mind.

But next time, try:

git remote add teor https://github.com/teor2345/tor.git
git fetch teor
git cherry-pick teor/bug24677

Also, in future, adding extra commits for each review helps us review faster, because it's easier to see what has changed.

So I make the comment changes on my commit if you can give me a patch file of the commit I will add it :-).

All changes are in my github branch bug24677

Thanks for the update!

I'm not sure if nickm will mind that you used "Minor features" on a bugfix ticket. I'll leave that up to him.

Okay, I will follow your advice for the next time, thanks!

Also, I changed the "Minor features" to "Minor bugfix".

looks okay to me, and seems to work: merged to master!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 1h 36m

moved from legacy/trac#24677 (moved)

added Bug First Contribution labels and removed 1 deleted label

added IPv6 Tests labels and removed 1 deleted label