Make geoip use channel_is_client so it ignores flapping relays

In channel_do_open_actions(), we probably want to use channel_is_client() rather than connection_or_digest_is_known_relay().

    /* only report it to the geoip module if it's not a known router */
    if (!connection_or_digest_is_known_relay(chan->identity_digest)) {
      if (channel_get_addr_if_possible(chan, &remote_addr)) {

Bugfix on legacy/trac#23533 (moved), 0.3.0.1-alpha.

We should make sure legacy/trac#24898 (moved) is fixed in any version we backport this to.

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

added 033-included-20180320 in Legacy / Trac 033-must in Legacy / Trac 033-triage-20180320 in Legacy / Trac component::core tor/tor in Legacy / Trac easy in Legacy / Trac intro in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::dgoulet in Legacy / Trac parent::23423 in Legacy / Trac points::0.5 in Legacy / Trac priority::medium in Legacy / Trac refactor in Legacy / Trac resolution::implemented in Legacy / Trac reviewer::nickm in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac technical-debt in Legacy / Trac tor-stats in Legacy / Trac type::defect in Legacy / Trac labels

Agreed.

My commit f5ff9f23 in my bug24898-more branch has this fix. Feel free to pull it out into its own fix and its own commit if you want that.

Trac:
Status: new to needs_review

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: 0.3.3.x-final

Trac:
Status: needs_review to needs_revision

This is fine, but it needs to be split into its own commit. (Or all the other code in the commit needs to be fixed.)

Some ticket dgoulet thinks must go in 033.

Trac:
Keywords: N/A deleted, 033-must added

Marking all tickets reached by current round of 033 triage.

Trac:
Keywords: N/A deleted, 033-triage-20180320 added

Mark 033-must tickets as triaged-in for 0.3.3

Trac:
Keywords: N/A deleted, 033-included-20180320 added

Taking over this one so we can get it in 033 asap.

Trac:
Owner: N/A to dgoulet
Status: needs_revision to accepted

Taken from part of arma's commit f5ff9f23

See branch: bug24904_033_01

Trac:
Status: accepted to needs_review

Assign Reviewer to nickm for the 26/03/18 week.

Trac:
Reviewer: N/A to nickm

looks fine; merged to 0.3.3

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed

changed time estimate to 4h

moved from legacy/trac#24904 (moved)

added Bug First Contribution labels and removed 1 deleted label

added 1 deleted label and removed 1 deleted label

added Technical Debt label and removed 1 deleted label