Add a test-rust make target to the Makefile
I can't quite work out how to run src/test/test_rust.sh by itself. It would be handy to have a target that runs it.
I tried, but I can't work out how to do that easily.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.3.3.x-final in legacy/trac
changed milestone to %Tor: 0.3.3.x-final in legacy/trac
- teor added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::nickm in Legacy / Trac points::0.5 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac review-group-32 in Legacy / Trac reviewer::isis in Legacy / Trac rust in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels
added component::core tor/tor in Legacy / Trac milestone::Tor: 0.3.3.x-final in Legacy / Trac owner::nickm in Legacy / Trac points::0.5 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac review-group-32 in Legacy / Trac reviewer::isis in Legacy / Trac rust in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels
- Owner
I think that setting the "abs_top_builddir" variable will be key -- that, or replacing the the "../../.." default with maybe "." ? I'm not sure.
Replying to nickm:
I think that setting the "abs_top_builddir" variable will be key -- that, or replacing the the "../../.." default with maybe "." ? I'm not sure.
No setting for abs_top_builddir worked for me, I think test_rust.sh might be missing a path reference somewhere. Typically, we would use
dirname "$0"
/../../.. but there's still the path reference issue.- Owner
I think using
dirname "$0"
here would get the sourcedir, not the builddir. - Owner
I've made a simple patch here:
tests_rust
.Trac:
Owner: N/A to nickm
Status: new to accepted - Owner
Trac:
Status: accepted to needs_review - Owner
Trac:
Keywords: N/A deleted, review-group-32 added Assigning tickets from review-group-32 to myself for review this week.
Trac:
Reviewer: N/A to isisLGTM. I tried using in both an in-tree build and an out-of-tree build.
Trac:
Status: needs_review to merge_ready- Owner
whoa, I can't believe anything I worked on actually worked correctly out-of-tree without extensive revision.
thanks for the review! merged to master.
Trac:
Resolution: N/A to implemented
Status: merge_ready to closed - Trac closed
closed
- Trac changed time estimate to 4h
changed time estimate to 4h
- Isis Lovecruft mentioned in issue legacy/trac#25386 (moved)
mentioned in issue legacy/trac#25386 (moved)
- Trac moved from legacy/trac#25071 (moved)
moved from legacy/trac#25071 (moved)