use C99 bool from stdbool.h instead of int everywhere

Trac:
Username: cyberpunks

changed milestone to %Tor: unspecified in legacy/trac

added c99 in Legacy / Trac coccinelle in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: unspecified in Legacy / Trac parent::13260 in Legacy / Trac priority::medium in Legacy / Trac reporter::cyberpunks in Legacy / Trac severity::normal in Legacy / Trac status::new in Legacy / Trac technical-debt in Legacy / Trac tor-client in Legacy / Trac type::defect in Legacy / Trac labels

When returning a boolean from a function, bool is the best we can do.

In a struct, a 1-bit field is better (unsigned int foo : 1).

I'm fine with returning a bool from functions that are logically boolean, but we shouldn't change the convention for functions where "0" indicates success and "-1" indicates an error.

moved from legacy/trac#27661 (moved)

added Bug label and removed 1 deleted label

added Client + 1 deleted label and removed 1 deleted label

removed Bug label

removed milestone

closed

added Deferred label

added Technical Debt label and removed 1 deleted label