Travis permissions error: failed to write Cargo.lock

changed milestone to %Tor: 0.3.3.x-final in legacy/trac

This issue appears to be reproducible: https://travis-ci.org/torproject/tor/jobs/486795693#L3638

This appears to be a build environment issue, because the same commit succeeded 4 days ago, but failed 2 days ago: https://travis-ci.org/torproject/tor/builds/485707435 https://travis-ci.org/torproject/tor/builds/484917361

It is probably related to Rust 1.32.0, which was released 14 days ago.

Trac:
Keywords: N/A deleted, 040-backport 035-backport 034-backport 033-backport? added

Replying to teor:

This appears to be a build environment issue, because the same commit succeeded 4 days ago, but failed 2 days ago: https://travis-ci.org/torproject/tor/builds/485707435 https://travis-ci.org/torproject/tor/builds/484917361

It is probably related to Rust 1.32.0, which was released 14 days ago. Did cargo start trying to write to Cargo.lock, even in frozen mode? I think this is happening in the distcheck jobs because maybe it tries to make the source tree read-only.

It's also possible that we stopped using frozen mode somewhere by mistake.

It might be related to rust nightly, since it seems we're using that:

$ if [[ "$RUST_OPTIONS" != "" ]]; then rustc --version; fi
rustc 1.34.0-nightly (d8a0dd7ae 2019-01-28)

Cargo recently started adding a comment to the start of the file: https://github.com/rust-lang/cargo/commit/3de188f1399da693c57054ed425bc0289752edd1

But cargo checks for frozen before writing. We are getting the write failed error, not the frozen error. https://github.com/rust-lang/cargo/blob/3de188f1399da693c57054ed425bc0289752edd1/src/cargo/ops/lockfile.rs#L105

Trac:
Milestone: Tor: 0.4.1.x-final to Tor: 0.4.0.x-final
Owner: N/A to nickm
Status: new to accepted

Aha, here is the bug.

When we say --enable-cargo-online-mode, we do not provide the "--frozen" flag as part of $CARGO_ONLINE.

This flag both gives cargo permission to download (which we want, since we're doing distcheck with --enable-cargo-online-mode) and gives it permission to update cargo.lock (which we don't, in this case).

Trac:
Keywords: 040-backport 035-backport 034-backport 033-backport? deleted, 040-backport 035-backport 034-backport 033-backport added

https://github.com/torproject/tor/pull/676 is a PR to fix this; the branch is ticket29244_033

Trac:
Status: accepted to needs_review
Actualpoints: N/A to .2

There is a case to be made that we should be using cargo's "--locked" option in this case, but I am going to suggest that we don't: It's not a great idea IMO to do things differently in a distcheck build.

This looks like a reasonable fix for me. I did not try to build it with nightly locally.

Trac:
Status: needs_review to merge_ready

Replying to teor:

Cargo recently started adding a comment to the start of the file: https://github.com/rust-lang/cargo/commit/3de188f1399da693c57054ed425bc0289752edd1

But cargo checks for frozen before writing. We are getting the write failed error, not the frozen error. https://github.com/rust-lang/cargo/blob/3de188f1399da693c57054ed425bc0289752edd1/src/cargo/ops/lockfile.rs#L105

For posterity, the above comments are where the fix comes from.

<ahf> armadev: the problem is that the place where tor.git is located is read/only, when we run distcheck it runs cargo which modifies the file by adding those two comments
<ahf> but because it's read-only it will fail
<ahf> but if those two lines of comment is there cargo wont touch the file

it is merged into maint-0.3.3 and later

Trac:
Status: merge_ready to closed
Milestone: Tor: 0.4.0.x-final to Tor: 0.3.3.x-final
Resolution: N/A to fixed

closed

changed time estimate to 4h

added 1h 36m of time spent

moved from legacy/trac#29244 (moved)

added Bug label and removed 1 deleted label

added CI Regression labels and removed 1 deleted label

Travis permissions error: failed to write Cargo.lock

Child items 0

Activity