Make relays into exits when ExitRelay is auto and IPv6Exit is 1

In legacy/trac#21530 (moved), we made relays exit if ExitRelay is auto, and either:

• ReducedExitPolicy is 1, or
• ExitPolicy is set

But a relay operator who sets IPv6Exit to 1 also wants to be an exit.

So we should add IPv6Exit 1 to the options that activate exits when ExitRelay is auto. We should also update the documentation (see legacy/trac#29612 (moved)).

changed milestone to %Tor: 0.4.1.x-final in legacy/trac

added 041-proposed in Legacy / Trac actualpoints::0.1 in Legacy / Trac component::core tor/tor in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.4.1.x-final in Legacy / Trac owner::neel in Legacy / Trac points::0.5 in Legacy / Trac priority::medium in Legacy / Trac resolution::implemented in Legacy / Trac reviewer-was-teor-20190422 in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tor-exit in Legacy / Trac tor-relay in Legacy / Trac type::defect in Legacy / Trac version::tor 0.3.5.1-alpha in Legacy / Trac labels

Trac:
Keywords: N/A deleted, tor-exit, tor-relay added

Trac:
Owner: N/A to neel
Status: new to assigned

Trac:
Cc: N/A to neel

PR is here: https://github.com/torproject/tor/pull/944

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to teor

This looks good, but we could do a bit of refactoring to make the code simpler. And we need to update the man page. See my comments on the pull request.

Trac:
Milestone: Tor: unspecified to Tor: 0.4.1.x-final
Actualpoints: N/A to 0.1
Status: needs_review to needs_revision

Made the changes and pushed them.

Trac:
Status: needs_revision to needs_review

hopefully this will let appear more nodes with exit flag

Hi neel,

On the pull request, I also asked:

Please update the man page entries for ExitRely and IPv6Exit.

Thanks!

Trac:
Status: needs_review to needs_revision

Man page updated and pushed.

Trac:
Status: needs_revision to needs_review

Just some grammar fixes, feel free to put this ticket in merge_ready after you've applied them.

Trac:
Status: needs_review to needs_revision

Made the changes and pushed them.

Trac:
Status: needs_revision to merge_ready

If these tickets go back in to needs_review, and I am on leave, they will need another reviewer.

Trac:
Reviewer: teor to N/A
Keywords: N/A deleted, reviewer-was-teor-20190422 added

LGTM; merged.

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 4h

added 48m of time spent

moved from legacy/trac#29613 (moved)

added Bug label and removed 1 deleted label

added IPv6 Relay labels and removed 1 deleted label