Unify parsing code for control.c

changed milestone to %Tor: 0.4.1.x-final in legacy/trac

Trac:
Parent Ticket: legacy/trac#29210 (moved)
Child Ticket(s): legacy/trac#29984 (moved)

added actualpoints::3 in Legacy / Trac component::core tor/tor in Legacy / Trac dgoulet-merge in Legacy / Trac milestone::Tor: 0.4.1.x-final in Legacy / Trac owner::nickm in Legacy / Trac parent::29210 in Legacy / Trac points::3 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::catalyst in Legacy / Trac severity::normal in Legacy / Trac sponsor::31-can in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels

I have a WIP branch as control_command_refactor; there are a few more tests and commands to go.

Now it handles all the commands, and 'test-stem' passes. PR at https://github.com/torproject/tor/pull/919

Trac:
Sponsor: N/A to Sponsor31-can
Type: defect to enhancement
Status: assigned to needs_review

Trac:
Actualpoints: N/A to 3

Per request from catalyst, I have rebased the branch as control_command_refactor_v2 and created a PR at https://github.com/torproject/tor/pull/940 .

Trac:
Reviewer: N/A to catalyst

So far, I looked at

d1f5957c4e Improve handling of controller commands

through

e3fcbffbb8 Use parsing code for the simpler controller commands.

These look good. I commented on the pull request about a few technical debt issues and some minor spelling and naming things.

This set of commits seems to form a logical grouping and they could probably have been in their own child ticket/PR.

Looking at

bb2062dd76 kvline: handle empty alues as well as empty keys

through

5d3dcd6fc9 Update more controller commands, now that we have kvline support

Overall this looks good, and deletes a lot of repetitive code.

There's a typo in the bb2062dd76 summary.

See technical debt comment in the pull request for control_cmd_parse_args(), and maybe a few more minor comments.

Okay, I've caught up on the requested revisions.

Replying to nickm:

Okay, I've caught up on the requested revisions. Thanks! Those look good so far. I'm still working through the rest of that branch.

Looking at

3eed319e4f Use new parser logic for SETCONF/RESETCONF code.

through

62695a9307 squash! kvline: handle empty alues as well as empty keys

Overall this looks good! I like how much smaller control_setconf_helper() became.

I wrote a few small comments on the pull request.

Updated the branch, responded to comments. Ready to go?

Replying to nickm:

Updated the branch, responded to comments. Ready to go? Thanks! I left one more comment on the pull request, which you may address at your option.

Trac:
Status: needs_review to merge_ready

I've takedn your suggestion, and squashed the branch as control_command_refactor_v3.

New PR for merge at https://github.com/torproject/tor/pull/980 ; let's give CI another chance on it before we merge.

Trac:
Keywords: N/A deleted, dgoulet-merge added

Merged! Woot

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 24h