Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,079
    • Issues 1,079
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 23
    • Merge Requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor
  • Issues
  • #32349

Closed
Open
Created Oct 31, 2019 by David Goulet@dgoulet😈Owner

hs-v2: Intro point circuit TIMEOUT failure is not reported

This was found while I was working on legacy/trac#32020 (moved).

For v2, we report a TIMEOUT circuit failure within circuit_about_to_free(). The following code is the snippet on how we check if the circuit timed out:

int reason = circ->marked_for_close_reason;
int timed_out = (reason == END_CIRC_REASON_TIMEOUT);

However, in circuit_mark_for_close_(), if the circuit is an origin one, which is the case for all HS client circuit, the marked_for_close_reason is set to END_CIRC_REASON_NONE so we don't send back that reason back within the destroy cell.

The fix is that we should be looking at marked_for_close_orig_reason instead.

We need to backport this.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.5.x-freeze
Milestone
Tor: 0.4.5.x-freeze (Past due)
Assign milestone
Time tracking
None
Due date
None