hs-v3: Report invalid onion address SOCKS5 extended error code

changed milestone to %Tor: 0.4.3.x-final in legacy/trac

Trac:
Parent Ticket: legacy/trac#30022 (moved)

Branch: ticket32546_043_01 PR: https://github.com/torproject/tor/pull/1551

Trac:
Status: assigned to needs_review

Trac:
Parent: legacy/trac#30022 (moved) to legacy/trac#14389 (moved)

Trac:
Parent: legacy/trac#14389 (moved) to legacy/trac#30022 (moved)

Looks good! Missing a changes file, and I just noticed that legacy/trac#30382 (moved) was also missing a changes file. So if possible please provide for both!

Thanks!

Trac:
Status: needs_review to needs_revision

New fixup commit pushed for the manpage. Then an extra commit for the legacy/trac#30382 (moved) changes file (which includes this change).

Finally, spec branch to not forget:

Spec: ticket32546_01

Trac:
Status: needs_revision to needs_review

+          X'F6' Onion Service Invalid Address
+
+            The given .onion address is invalid. Either the checksum doesn't
+            match or the length or encoding.
+

Hm. I think this description is not right, since we don't return F6 if the onion address has the wrong length (since that's how we realize it's a v3 address). Please describe the exact cases under which we return F6 since it might be used as part of the error page in legacy/trac#30022 (moved). Also, let's mention that it's v3 exclusive.

(Also the PR did not update for some reason)

Trac:
Status: needs_review to needs_revision

Replying to asn:

Hm. I think this description is not right, since we don't return F6 if the onion address has the wrong length (since that's how we realize it's a v3 address). Please describe the exact cases under which we return F6 since it might be used as part of the error page in legacy/trac#30022 (moved). Also, let's mention that it's v3 exclusive.

Pushed as fixup. Actually, all ExtendedErrors are v3 only so I added a note to each code about it.