Allow ONION_CLIENT_AUTH_ADD credentials to be made permanent
The Permanent flag of ONION_CLIENT_AUTH_ADD is not implemented yet.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- George Kadianakis changed milestone to %Tor: 0.4.3.x-final in legacy/trac
changed milestone to %Tor: 0.4.3.x-final in legacy/trac
Trac:
Parent Ticket: legacy/trac#14389 (moved)- George Kadianakis added 042-deferred-20190918 in Legacy / Trac actualpoints::1.2 in Legacy / Trac component::core tor/tor in Legacy / Trac hs-auth in Legacy / Trac milestone::Tor: 0.4.3.x-final in Legacy / Trac network-team-roadmap-september in Legacy / Trac parent::14389 in Legacy / Trac points::2 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::dgoulet in Legacy / Trac severity::normal in Legacy / Trac sponsor::27-must in Legacy / Trac status::closed in Legacy / Trac tbb-usability in Legacy / Trac tor-hs in Legacy / Trac type::defect in Legacy / Trac ux-team in Legacy / Trac labels
added 042-deferred-20190918 in Legacy / Trac actualpoints::1.2 in Legacy / Trac component::core tor/tor in Legacy / Trac hs-auth in Legacy / Trac milestone::Tor: 0.4.3.x-final in Legacy / Trac network-team-roadmap-september in Legacy / Trac parent::14389 in Legacy / Trac points::2 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::dgoulet in Legacy / Trac severity::normal in Legacy / Trac sponsor::27-must in Legacy / Trac status::closed in Legacy / Trac tbb-usability in Legacy / Trac tor-hs in Legacy / Trac type::defect in Legacy / Trac ux-team in Legacy / Trac labels
- Author Contributor
OK here we go:
little-t-tor branch: https://github.com/torproject/tor/pull/1563 torspec branch: https://github.com/torproject/torspec/pull/94
Some comments and changes from the original trajectory:
- Adding a Permanent credential requires the
ClientOnionAuthDir
torrc option to be set, and also the directory to be already created. When this is done, permanent credentials will be created as files within that directory. - Nicknames have been completely ditched because of the huge PITA that it would be to add them to the non-forward-compatible client auth file format (as described by the corresponding commit messages both in torspec and tor). In the future we can consider adding them but that would be even more work. For now, this could be handled in the TB layer if needed.
- The REMOVE control port command will also remove the corresponding client auth files if they are permanent and they exist.
Trac:
Actualpoints: N/A to 1.2
Status: new to needs_review - Adding a Permanent credential requires the
- Owner
Trac:
Reviewer: N/A to dgoulet - Owner
Good stuff. Minor things on the PR.
Trac:
Status: needs_review to needs_revision - Author Contributor
Addressed issues! Please check again! :)
Trac:
Status: needs_revision to needs_review - Owner
Great! Merged!
(FYI, no changes file since this code hasn't been released yet. Was merged in master 2 weeks ago.)
Trac:
Status: needs_review to closed
Resolution: N/A to fixed - Trac closed
closed
- Trac changed time estimate to 16h
changed time estimate to 16h
- Trac added 9h 36m of time spent
added 9h 36m of time spent
- Trac moved from legacy/trac#32562 (moved)
moved from legacy/trac#32562 (moved)
- Gaba added Onion Services label and removed 1 deleted label
added Onion Services label and removed 1 deleted label