Build failure and warnings with svn 8308

Hi,

I use NetBSD 3_Stable...

First, there is a mistake in src/common/compat.h. I interpreted what I thought you meant and created this diff: clarity 141 -> svn di src/common/compat.h Index: src/common/compat.h

--- src/common/compat.h (revision 8308) +++ src/common/compat.h (working copy) @@ -90,7 +90,7 @@ #endif

/* GCC has several useful attributes. */ -#ifdef GNUC && GNUC_MAJOR >= 3 +#if defined(GNUC) && GNUC_MAJOR >= 3 #define ATTR_NORETURN attribute((noreturn)) #define ATTR_PURE attribute((pure)) #define ATTR_MALLOC attribute((malloc))

---

In addition, after fixing this, I find the following warnings as probable mistakes:

util.c: In function tor_strlower': util.c:311: warning: subscript has type char' util.c: In function tor_strupper': util.c:322: warning: subscript has type char'

config.c: In function get_default_nickname': config.c:1740: warning: subscript has type char'

I don't know if this functions properly, I do not want to install until it builds clean. --gene

[Automatically added by flyspray2trac: Operating System: All]

Trac:
Username: yancm