Tried to establish rendezvous on non-edge circuit

In #12997comment:6 nickm requested to open a new ticket if someone gets that warning again.

I get that warning since weeks on 0.4.1.6 about once a day on different relays. Even if legacy/trac#12997 (moved) is implemented i never saw a more specific warning than that simple line.

This is all the log shows me:

Dec 09 10:36:03.000 [notice] DoS mitigation since startup: 10 circuits killed with too many cells. 1835037 circuits rejected, 91 marked addresses. 711976 connections closed. 10660 single hop clients refused.
Dec 09 12:29:48.000 [warn] Tried to establish rendezvous on non-edge circuit
Dec 09 16:36:03.000 [notice] Heartbeat: Tor's uptime is 47 days 0:00 hours, with 23309 circuits open. I've sent 56816.96 GB and received 56583.09 GB.

Trac:
Username: computer_freak

changed milestone to %Tor: 0.4.3.x-final in legacy/trac

Trac:
Parent Ticket: legacy/trac#15618 (moved)

added 043-should in Legacy / Trac BugSmashFund in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.4.3.x-final in Legacy / Trac owner::dgoulet in Legacy / Trac parent::15618 in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac reporter::computer_freak in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::asn in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tor-hs in Legacy / Trac tor-log in Legacy / Trac tor-relay in Legacy / Trac type::defect in Legacy / Trac version::tor 0.4.1.6 in Legacy / Trac labels

I just see that the ticket legacy/trac#12997 (moved) is not exactly the same error message than the one i get. Seems Google trapped me into it:) So if possible please rename this ticket.

Anyway i get the error message i provided and dont know what to do with it.

Trac:
Username: computer_freak

Thanks! I am going to close this one in favor of legacy/trac#15618 (moved). And I've left a note on legacy/trac#12297 (closed) for the next person who gets caught in your Google trap. :)

Trac:
Resolution: N/A to duplicate
Status: new to closed

It's not actually a duplicate, so we should do the same thing we did in legacy/trac#15618 (moved), and turn this warning into a protocol warning.

Since these seem to be recurring issues in other people's code, I suggest we make all these warnings protocol warnings:

• Tried to establish rendezvous on non-edge circuit
• Duplicate rendezvous cookie in ESTABLISH_RENDEZVOUS
• Impossibly short INTRODUCE1 cell on circuit
• Incorrect signature on ESTABLISH_INTRO cell
• Couldn't decode public key

Trac:
Milestone: N/A to Tor: 0.4.3.x-final
Version: N/A to Tor: 0.4.1.6
Resolution: duplicate to N/A
Points: N/A to 0.1
Status: closed to reopened
Keywords: N/A deleted, BugSmashFund, tor-log, tor-relay, 043-should, tor-hs added

Trac:
Summary: Tried to establish rendezvous on non-OR or non-edge circuit to Tried to establish rendezvous on non-edge circuit
Parent: N/A to legacy/trac#15618 (moved)

Oops! Good catch.

Yes, I think turning those into protocol-warns is a good direction to go. (I haven't looked at each of them to be convinced that each of them should change, but I expect and hope that we find they should.)

I have just noticed the same [warn] thirty-six (36) times on eleven (11) of my sixteen (16) relays. The first one, and the most recent one, being:-

Dec 07 03:49:28.000 [warn] Tried to establish rendezvous on non-edge circuit
Dec 12 10:23:33.000 [warn] Tried to establish rendezvous on non-edge circuit

All of my relays are the same, namely "Ubuntu 18.04.3 LTS bionic" and Tor version "0.4.1.6". They are spread across ten internet providers and seven countries.

Trac:
Username: fingau

Trac:
Owner: N/A to neel
Cc: N/A to neel
Status: reopened to assigned

Trac:
Owner: neel to N/A

Trac:
Cc: neel to N/A
Status: assigned to new

Trac:
Owner: N/A to dgoulet
Status: new to assigned

I've turned a number of log statement to protocol warning within rendmid.c. I believe all of them can be triggered remotely so no need to warn or info if they happen.

Branch: ticket32706_043_01 PR: https://github.com/torproject/tor/pull/1700

Trac:
Status: assigned to needs_review
Reviewer: N/A to asn

LGTM! Merged!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

changed time estimate to 48m

moved from legacy/trac#32706 (moved)

added Bug label and removed 1 deleted label

added Relay + 1 deleted label and removed 1 deleted label

added BugSmashFund label

added Onion Services label and removed 1 deleted label