Tor should lower-case its BridgeDistribution string

See comment:8 in legacy/trac#32547 (moved), where phw tells a bridge operator that they need to set BridgeDistribution to "none", because using "None" is not right.

That isn't a good user experience, and it's easy to fix.

One option is that inside check_bridge_distribution_setting() when we do if (!strcmp(bd, RECOGNIZED[i])) we should do strcasecmp instead. That is, don't complain if it's a recognized value and the only issue is that it's not all lowercase.

But a better option imo is that we lowercase it in place first, so that if the user types None, bridgedb still sees none.

changed milestone to %Tor: 0.4.2.x-final in legacy/trac

added 035-backport in Legacy / Trac 041-backport in Legacy / Trac 042-backport in Legacy / Trac anticensorship-wants in Legacy / Trac component::core tor/tor in Legacy / Trac consider-backport-after-0432 in Legacy / Trac easy in Legacy / Trac fast-fix in Legacy / Trac milestone::Tor: 0.4.2.x-final in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::dgoulet in Legacy / Trac severity::normal in Legacy / Trac sponsor::28 in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac version::tor 0.3.2.3-alpha in Legacy / Trac labels

Trac:
Keywords: N/A deleted, backport easy anticensorship-wants added
Milestone: N/A to Tor: 0.4.3.x-final

Trac:
Keywords: backport easy anticensorship-wants deleted, backport easy anticensorship-wants fast-fix 043-should added

Patches in https://github.com/torproject/tor/pull/1668

phw, does this work like what you expected?

Trac:
Status: new to needs_review

Looks good to me, thanks ahf!

Cool. Thanks for taking a look. I'll await review from a network team person.

Merged!

Moving to 042 component for backport consideration.

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready
Milestone: Tor: 0.4.3.x-final to Tor: 0.4.2.x-final
Keywords: backport easy anticensorship-wants fast-fix 043-should deleted, 035-backport 041-backport 042-backport easy anticensorship-wants fast-fix 043-should added

Trac:
Sponsor: N/A to Sponsor28

I would vote 'no backport' for this one, since it's not a security fix and other components are going to have to tolerate the old behavior for a while anyway.

(Also because my high level backport policy is "by default, no backport", with the goal of making the changelogs in new Tor stables small enough that Debian won't be horrified.)

This fixes a serious usability issue for bridge operators, so we should backport it to all supported versions.

Trac:
Keywords: N/A deleted, consider-backport-after-0432 added

Is there some minimal version of this patch that we could backport?

https://github.com/torproject/tor/pull/1694 contains a backported patch to 0.4.2 maint. Awaiting CI.

I think you removed these lines because they are redundant?

    if (strchr(bd, '\n') || strchr(bd, '\r'))
      bd = escaped(bd);

Maybe we should log a BUG() instead?

Trac:
Status: merge_ready to needs_revision

Trac:
Keywords: 035-backport 041-backport 042-backport easy anticensorship-wants fast-fix 043-should deleted, 035-backport 041-backport 042-backport easy anticensorship-wants fast-fix added

Actually, I'm just going to backport this as-is.

Trac:
Status: needs_revision to merge_ready

Cherry-picked to 0.3.5, and merged forwards. Used an "ours" merge from 0.4.2 to 0.4.3, because we already merged PR 1668 to 0.4.3.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed
Version: N/A to Tor: 0.3.2.3-alpha

closed

moved from legacy/trac#32753 (moved)

added Feature First Contribution labels and removed 1 deleted label

added 1 deleted label and removed 1 deleted label

added For Anticensorship Team label and removed 1 deleted label