Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 345
    • Issues 345
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #32753
Closed
Open
Issue created Dec 13, 2019 by Roger Dingledine@armaReporter

Tor should lower-case its BridgeDistribution string

See comment:8 in legacy/trac#32547 (moved), where phw tells a bridge operator that they need to set BridgeDistribution to "none", because using "None" is not right.

That isn't a good user experience, and it's easy to fix.

One option is that inside check_bridge_distribution_setting() when we do if (!strcmp(bd, RECOGNIZED[i])) we should do strcasecmp instead. That is, don't complain if it's a recognized value and the only issue is that it's not all lowercase.

But a better option imo is that we lowercase it in place first, so that if the user types None, bridgedb still sees none.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking