Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,079
    • Issues 1,079
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 23
    • Merge Requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor
  • Issues
  • #32753

Closed
Open
Created Dec 13, 2019 by Roger Dingledine@armaReporter

Tor should lower-case its BridgeDistribution string

See comment:8 in legacy/trac#32547 (moved), where phw tells a bridge operator that they need to set BridgeDistribution to "none", because using "None" is not right.

That isn't a good user experience, and it's easy to fix.

One option is that inside check_bridge_distribution_setting() when we do if (!strcmp(bd, RECOGNIZED[i])) we should do strcasecmp instead. That is, don't complain if it's a recognized value and the only issue is that it's not all lowercase.

But a better option imo is that we lowercase it in place first, so that if the user types None, bridgedb still sees none.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.2.x-final
Milestone
Tor: 0.4.2.x-final
Assign milestone
Time tracking
None
Due date
None