Use tor_api.h entry points for ntmain.c

ntmain.c currently launches tor by calling several functions in main.c directly, but this has led to the two getting out of sync. (See legacy/trac#32778 (moved) for one example.)

Instead, ntmain.c should use the functions in tor_api.h to launch Tor.

changed milestone to %Tor: unspecified in legacy/trac

Trac:
Child Ticket(s): legacy/trac#32984 (moved)

added 044-deferred in Legacy / Trac BugSmashFund in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: unspecified in Legacy / Trac owner::nickm in Legacy / Trac points::.2 in Legacy / Trac priority::medium in Legacy / Trac reviewer::ahf in Legacy / Trac severity::normal in Legacy / Trac status::needs-revision in Legacy / Trac type::defect in Legacy / Trac labels

See ticket32883 with PR at https://github.com/torproject/tor/pull/1635

(see legacy/trac#23081 (moved) for another bug caused by this duplicated code)

Edit: fix ticket number typo

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to ahf

Looks good.

Trac:
Status: needs_review to merge_ready

merged!

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

Based on ticket:32778#comment:22 and ticket:32778#comment:24, it looks like the NT service stuff doesn't work at all (stalls, no output, etc) after these changes, while the more minimal fix in legacy/trac#32778 (moved) does.

Trac:
Cc: N/A to catalyst, Vort
Status: closed to reopened
Resolution: implemented to N/A

Maybe, given our release timeframe, we should consider reverting this in 0.4.3, and investigating more closely in 0.4.4?

Replying to nickm:

Maybe, given our release timeframe, we should consider reverting this in 0.4.3, and investigating more closely in 0.4.4?

Let's revert this change.

The revert might be complicated. I did an "ours" merge of legacy/trac#32778 (moved) to avoid conflicts with the code in this ticket, which we now want to revert. Let's make sure that legacy/trac#32778 (moved) ends up in master for 0.4.3, and this code does not.

Let's make a new PR that reverts PR 1635, and merges PR 1634.

Trac:
Status: reopened to needs_revision

I've made a child ticket to revert the change here. We can try to figure out more about making this approach work in 0.4.4

Trac:
Milestone: Tor: 0.4.3.x-final to Tor: 0.4.4.x-final
Keywords: N/A deleted, BugSmashFund added

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Trac:
Milestone: Tor: 0.4.4.x-final to Tor: unspecified
Keywords: N/A deleted, 044-deferred added

changed time estimate to 1h 36m

mentioned in issue legacy/trac#32884 (moved)

mentioned in issue legacy/trac#32984 (moved)

moved from legacy/trac#32883 (moved)

mentioned in issue #32984 (closed)

added Bug label and removed 1 deleted label

added Deferred + 1 deleted label and removed 1 deleted label

added BugSmashFund label

added Icebox Project Ideas + 1 deleted label

unassigned @nickm

removed Bug label

removed milestone

added Technical Debt label and removed 1 deleted label

Not currently planning ntmain refactorings.

closed