Alphabetized the Server and Directory Server Options
Thanks! It looks like MaxOnionQueueDelay is out of order, but the rest of Server and Stats options are in order or correctly commented. I'll check the Directory Server options in another comment.
Created a new section titled Statistics Options. Pulled out all the stats-related and extra-info related options, and put them into this new section.
Looks good! I would suggest a few minor changes to the introductory text. Change "following options describe" to "following options affect". Change "that Tor collects and writes" to "that Tor relays collect and publish". What do you think?
Should I pull out the DownloadExtraInfo option (that is presently under the Client Options section) and move it under Statistics Options?
I think this still belongs in the Client Options section, because it doesn't affect how relays report their statistics.
Also, I think RephistTrackTime might belong in the stats section, because it changes the length of the period that relays use to report their bandwidth stats. (I'm still researching this. Anyone else have ideas?)
I'll check the Directory Server options in another comment.
Looks like I got my script for checking the Directory Server options wrong, and it was capturing more than I expected. The Directory Server options look like they're sorted correctly.
Alphabetized the Server and Directory Server Options
Thanks! It looks like MaxOnionQueueDelay is out of order, but the rest of Server and Stats options are in order or correctly commented. I'll check the Directory Server options in another comment.
Created a new section titled Statistics Options. Pulled out all the stats-related and extra-info related options, and put them into this new section.
Looks good! I would suggest a few minor changes to the introductory text. Change "following options describe" to "following options affect". Change "that Tor collects and writes" to "that Tor relays collect and publish". What do you think?
Should I pull out the DownloadExtraInfo option (that is presently under the Client Options section) and move it under Statistics Options?
I think this still belongs in the Client Options section, because it doesn't affect how relays report their statistics.
Also, I think RephistTrackTime might belong in the stats section, because it changes the length of the period that relays use to report their bandwidth stats. (I'm still researching this. Anyone else have ideas?)
Everything with "Rephist" in the name should go under statistics.
Created a new section titled Statistics Options. Pulled out all the stats-related and extra-info related options, and put them into this new section.
Looks good! I would suggest a few minor changes to the introductory text. Change "following options describe" to "following options affect". Change "that Tor collects and writes" to "that Tor relays collect and publish". What do you think?
Should I pull out the DownloadExtraInfo option (that is presently under the Client Options section) and move it under Statistics Options?
I think this still belongs in the Client Options section, because it doesn't affect how relays report their statistics.
I agree, the DownloadExtraInfo option works on clients and relays, so it should not be in a relay-only section.
Also, I think RephistTrackTime might belong in the stats section, because it changes the length of the period that relays use to report their bandwidth stats. (I'm still researching this. Anyone else have ideas?)
Everything with "Rephist" in the name should go under statistics.
Authorities use it in their votes, clients and relays use it to check whether another relay might be up.
So I think RephistTrackTime belongs in some sort of "common options" section. (Or in client options, if there isn't a common options section.)
The bandwidth stats interval is a fixed constant, as are all stats intervals. We don't let people configure them, it would make metrics code much more complex :-)
Hi swati, I think I agree with teor after thinking about it some more. Please leave RephistTrackTime alone, or move it to General Options. Its content might need improvement (to make it clear that all kinds of entities use it), but we can do that separately.