Skip to content
Snippets Groups Projects
New look: Off

Logs spammed by address changes while it did not happen

    • Closed Issue created by Guinness @guinness

    Looking at my notices logs on 0.4.5.1-alpha , they are spammed by this:

    Nov 07 22:17:06.000 [notice] Our IP Address has changed from 212.47.236.95 to ???; rebuilding descriptor (source: METHOD=NONE).
Nov 07 22:17:23.000 [notice] Self-testing indicates your ORPort 212.47.236.95:443 is reachable from the outside. Excellent.

    My relay is a VPS hosted behind a NAT.

    $ uname -a
Linux hermoth.oudin.red 4.19.53-mainline-rev1 #1 SMP Wed Jun 19 23:30:45 UTC 2019 x86_64 GNU/Linux
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items ...

    • Activity

    • Roger Dingledine
      Roger Dingledine @arma ·
      Reporter

      Looks like a good and important bug, and related to all the address discovery things that are new in 0.4.5.1-alpha.

    • Guinness
      Guinness @guinness ·
      Author Contributor

      Confirmed on my laptop on a test relay. I'll start the bisect from 0.4.4.5

    • Guinness
      Guinness @guinness ·
      Author Contributor

      Found it b30ac328:

      .-(11:19:53)-(~/src/tor)------------------------------------------(git)-[tor/bf5bf33...|bisect]-(neha@grossbaf)
`---> git bisect good
b30ac328c5a07aaa4a806af3314b48d10082448a is the first bad commit
commit b30ac328c5a07aaa4a806af3314b48d10082448a
Merge: 9e2435c25f bf5bf33661
Author: Nick Mathewson <nickm@torproject.org>
Date:   Tue Sep 15 08:52:45 2020 -0400

    Merge branch 'maint-0.4.4'
    
    "ours" to avoid version bump

      It's a merge commit, maybe the ours method is the culprit since it introduced a bug during the merge.

      I'll dig in the commit to see what has possibly created the bug, but it's a huge one so it will take some time.

      EDIT: I guess I found the culprit function, I just need some rest for now before trying to fix it.

      Edited by Guinness
    • Guinness
      Guinness @guinness ·
      Author Contributor

      Don't know why but find_my_address is unable to resolve the address. I'll check how the first discovery is done to see what is wrong in this function (and mostly in the table iteration

      Maybe @dgoulet will have a better insight than me on what is going on since he committed this function?

    • David Goulet
      David Goulet @dgoulet ·
      Owner

      Can you post the debug logs of this, just the first part? We would learn how tor is able to find the address but then somehow gets notified of an IP change to ???.

      From there, I can help you walk the issue. Thanks!

    • Nick Mathewson changed milestone to %Tor: 0.4.5.x-stable

      changed milestone to %Tor: 0.4.5.x-stable

    • Nick Mathewson added Regression label

      added Regression label

    • Guinness
      Guinness @guinness ·
      Author Contributor

      Here are the debug log around the bug :

      Nov 08 15:05:49.000 [debug] tor_tls_read(): read returned r=-1, err=-2
Nov 08 15:05:49.000 [debug] connection_buf_read_from_socket(): After TLS read of 514: 536 read, 0 written
Nov 08 15:05:49.000 [debug] connection_or_process_cells_from_inbuf(): 67: starting, inbuf_datalen 514 (0 pending in tls object).
Nov 08 15:05:49.000 [debug] connection_or_process_cells_from_inbuf(): 67: starting, inbuf_datalen 0 (0 pending in tls object).
Nov 08 15:05:49.000 [debug] get_address_from_config(): Attempting to get address from configuration
Nov 08 15:05:49.000 [info] get_address_from_config(): No Address option found in configuration.
Nov 08 15:05:49.000 [debug] get_address_from_orport(): Attempting to get address from ORPort
Nov 08 15:05:49.000 [info] address_can_be_used(): Address '0.0.0.0' is a private IP address. Tor relays that use the default DirAuthorities must have public IP addresses.
Nov 08 15:05:49.000 [debug] get_address_from_interface(): Attempting to get address from network interface
Nov 08 15:05:49.000 [debug] get_interface_address6(): Found internal interface address '192.168.0.26'
Nov 08 15:05:49.000 [info] address_can_be_used(): Address '192.168.0.26' is a private IP address. Tor relays that use the default DirAuthorities must have public IP addresses.
Nov 08 15:05:49.000 [debug] get_address_from_hostname(): Attempting to get address from local hostname
Nov 08 15:05:49.000 [info] address_can_be_used(): Address '127.0.1.1' is a private IP address. Tor relays that use the default DirAuthorities must have public IP addresses.
Nov 08 15:05:49.000 [info] find_my_address(): Unable to find our IP address.
Nov 08 15:05:49.000 [notice] Our IP Address has changed from 91.170.172.234 to ???; rebuilding descriptor (source: METHOD=NONE).
Nov 08 15:05:49.000 [debug] get_address_from_config(): Attempting to get address from configuration
Nov 08 15:05:49.000 [info] get_address_from_config(): No Address option found in configuration.
Nov 08 15:05:49.000 [debug] get_address_from_orport(): Attempting to get address from ORPort
Nov 08 15:05:49.000 [info] get_address_from_orport(): Address found from ORPort: 2a01:e0a:2ab:3a80:4c89:649:bec0:48dd
Nov 08 15:05:49.000 [info] mark_my_descriptor_dirty(): Decided to publish new relay descriptor: IP address changed
Nov 08 15:05:49.000 [info] router_rebuild_descriptor(): Rebuilding relay descriptor
Nov 08 15:05:49.000 [debug] get_address_from_config(): Attempting to get address from configuration
Nov 08 15:05:49.000 [info] get_address_from_config(): No Address option found in configuration.
Nov 08 15:05:49.000 [debug] get_address_from_orport(): Attempting to get address from ORPort
Nov 08 15:05:49.000 [info] address_can_be_used(): Address '0.0.0.0' is a private IP address. Tor relays that use the default DirAuthorities must have public IP addresses.
Nov 08 15:05:49.000 [debug] get_address_from_interface(): Attempting to get address from network interface
Nov 08 15:05:49.000 [debug] get_interface_address6(): Found internal interface address '192.168.0.26'
Nov 08 15:05:49.000 [info] address_can_be_used(): Address '192.168.0.26' is a private IP address. Tor relays that use the default DirAuthorities must have public IP addresses.
Nov 08 15:05:49.000 [debug] get_address_from_hostname(): Attempting to get address from local hostname
Nov 08 15:05:49.000 [info] address_can_be_used(): Address '127.0.1.1' is a private IP address. Tor relays that use the default DirAuthorities must have public IP addresses.
Nov 08 15:05:49.000 [info] find_my_address(): Unable to find our IP address.

      And my test torrc is

      DataDirectory /home/neha/src/tor/dir
ORPort 65333
Nickname GuinnessTest
DirPort 65334
ExitPolicy reject *:*
      Edited by Guinness
    • David Goulet
      David Goulet @dgoulet ·
      Owner

      Hmmm I will need more debug logs. We need to find out how that IP address is found and I suspect from possibly the directory authority. Can you just upload the full debug.log ?

    • Guinness
      Guinness @guinness ·
      Author Contributor

      Here it is: https://framadrop.org/lufi/r/7g5wKjE3C0#93RQK56JUeLaRohRb93l7+fSNjgyYmdkVcWXYHZuknk=

      I also guess it comes from the directory authority but in the debug log the first time the IP address is added is in a reject ExitPolicy. It is not logged that it comes from a directory authority.

      Nov 08 15:02:49.000 [debug] addr_policy_append_reject_addr(): Adding a reject ExitPolicy 'reject 91.170.172.234:*'
      Edited by Guinness
    • Guinness mentioned in merge request !209 (closed)

      mentioned in merge request !209 (closed)

    • N
      Neel Chauhan @neel ·
      Guest

      @guinness thanks for the PR!

      This bug hurts relays behind NAT (e.g. home broadband, university ISPs, AWS/Azure, etc.).

      I seen this on a relay behind NAT, using Tor 0.4.5.1-alpha from FreeBSD packages (but on the plus side, IPv6 is now autodetected, so yay dual stack!).

      Edited by Neel Chauhan
    • David Goulet
      David Goulet @dgoulet ·
      Owner

      Fixed in a5538a36

    • David Goulet closed

      closed

    Please register or sign in to reply