Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 319
    • Issues 319
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #40263
Closed
Open
Created Jan 28, 2021 by Nick Mathewson@nickm🥄Owner

CID 1472584: Error handling issues in check_descriptor_ipaddress_changed()

It looks like Coverity wants us to check the return value on relay_find_addr_to_publish.

 *** CID 1472584:  Error handling issues  (CHECKED_RETURN)
/src/feature/relay/router.c: 2700 in check_descriptor_ipaddress_changed()
2694           previous = &my_ri->ipv6_addr;
2695         }
2696     
2697         /* Attempt to discovery the publishable address for the family which will
2698          * actively attempt to discover the address if we are configured with a
2699          * port for the family. */
>>>     CID 1472584:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "relay_find_addr_to_publish" without checking return value (as is done elsewhere 4 out of 5 times).
2700         relay_find_addr_to_publish(get_options(), family, RELAY_FIND_ADDR_NO_FLAG,
2701                                    &current);
2702     

Assigning to @dgoulet, but please let me know if you want me to do this.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking