"No more HSDir available to query" log message is confusing
Summary
The "No more HSDir available to query" log message does not make it clear whether the problem is on the client's end, the onion's end, or some other network issue. This makes it harder for the user to understand what they should do about it.
Steps to reproduce:
No idea how to reproduce this log message; it happened for a few hours when the Debian apt onion went down on 2022 August 5, and has not occurred since.
What is the current bug behavior?
The log message is "No more HSDir available to query".
What is the expected behavior?
The log message should be along the lines of "No more HSDir available to query; probably this means the onion service went away" according to @arma on IRC (see #tor logs from 2022 August 5).
Environment
- Which version of Tor are you using? Run
tor --version
to get the version if you are unsure. - Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.
- Debian Bullseye (with a few irrelevant packages pulled in from other Debian suites).
- Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.
- Bug is present in both Debian Bullseye's
apt
package and latest Git source code from Tor Project.
- Bug is present in both Debian Bullseye's
Relevant logs and/or screenshots
N/A.
Possible fixes
Looks like this line should be amended: http://eweiibe6tdjsdprb4px6rqrzzcsi22m4koia44kc5pcjr7nec2rlxyad.onion/tpo/core/tor/-/blob/982c50401c5e9bde6a1c3ef4bf7a9019e007ab03/src/feature/hs/hs_client.c#L89