Exits have too much unreachable traffic hitting them

Note by Mike: As per comment #40995 (comment 3135791), the root issue is that too much unreachable address traffic is exiting from exits. This is separate from the Exit flag issue, and not actually fixed by the private_nets fix.

Click to expand

**Original reporter text**: This is regarding open issue https://gitlab.torproject.org/tpo/core/torspec/-/issues/158#note_3073276

I'm running an exit relay (FAFD01A491EBCA474C1E972A24E70B7F54535107) with modified tor code to filter more RFC networks eliminating above linked issue.

The patch I'm using:

diff --git a/src/core/or/policies.c b/src/core/or/policies.c
index 4641632b60..0574eddf59 100644
--- a/src/core/or/policies.c
+++ b/src/core/or/policies.c
@@ -86,10 +86,14 @@ typedef struct policy_summary_item_t {
  *  just change this without a proper migration plan and a proposal and stuff.
  */
 static const char *private_nets[] = {
-  "0.0.0.0/8", "169.254.0.0/16",
-  "127.0.0.0/8", "192.168.0.0/16", "10.0.0.0/8", "172.16.0.0/12",
-  "[::]/8",
-  "[fc00::]/7", "[fe80::]/10", "[fec0::]/10", "[ff00::]/8", "[::]/127",
+  "0.0.0.0/8",        "10.0.0.0/8",       "100.64.0.0/10",  "127.0.0.0/8",
+  "169.254.0.0/16",   "172.16.0.0/12",    "192.0.2.0/24",   "192.168.0.0/16",
+  "198.18.0.0/15",    "198.51.100.0/24",  "203.0.113.0/24", "224.0.0.0/4",
+  "240.0.0.0/4",
+  "[::]/8",           "[0100::]/64",      "[2001:2::]/48",  "[2001:10::]/28",
+  "[2001:db8::]/32",  "[3ffe::]/16",      "[fc00::]/7",     "[fe80::]/10",
+  "[fec0::]/10",      "[ff00::]/8",
+  /** RFC7526 defines these but HE has valid announcements: "192.88.99.0/24", "[2002::]/16", */
   NULL
 };

GitLab Account has been requested.

/r0cket