Tor should complain if the user has configured a too-short CBT

The reporter of legacy/trac#5363 (moved) set the following torrc lines, and Tor got flaky:

LearnCircuitBuildTimeout 0
CircuitBuildTimeout 5

Perhaps Tor should warn the user if he/she/it has specified a non-adaptive circuit-build timeout and Tor is failing to build too many circuits.

changed milestone to %Tor: 0.2.3.x-final in legacy/trac

added component::core tor/tor in Legacy / Trac easy in Legacy / Trac milestone::Tor: 0.2.3.x-final in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac status::closed in Legacy / Trac tor-client in Legacy / Trac type::enhancement in Legacy / Trac labels

For 0.2.3.x, it's probably easier to just add a "Hey, if Tor breaks, here is why!" warning in options_validate() if you have turned off LearnCircuitBuildTimeout and set a low CircuitBuildTimeout value.

Trac:
Keywords: N/A deleted, easy added

Proposed fix is https://gitweb.torproject.org/user/andrea/tor.git/commit/4fb2a14faeb7505e51780fab2c610504edb2646b

Trac:
Status: new to needs_review

Needs a changes file (see doc/HACKING ""), and probably needs an additional sentence to say "If Tor isn't working, raise this value or turn LearnCircuitBuildTimeout back on"

Trac:
Status: needs_review to needs_revision

Requested changes made.

Trac:
Status: needs_revision to needs_review

Thank you! Merging now.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Keywords: easy deleted, easy tor-client added

Trac:
Component: Tor Client to Tor

closed

mentioned in issue legacy/trac#5458 (moved)

mentioned in issue legacy/trac#6304 (moved)

moved from legacy/trac#5452 (moved)

added Feature First Contribution labels and removed 1 deleted label

added Client label and removed 1 deleted label