Why is control_ports_write_to_file() called from options_act_reversible()?
control_ports_write_to_file() writes out to a file every single time we setconf something. That's a minor issue, but ok.
What's weirder is that we call it from options_act_reversible(). There's a codepath (where the logs fail to initialize) where we end up refusing the new options but the control ports file remains written with the new options.
I think the better answer is to call it from options_act(). Also, it'd be slightly cleaner to pass 'options' in to the function.
Optimistically marking as easy (what could go wrong ;).