Safe cookie authentication failure replies do not end with a CRLF

On the control socket, AUTHCHALLENGE's failure replies do not end with a CRLF.

+12:29% nc localhost 9100
AUTHCHALLENGE SAFEOHJOIE
513 AUTHCHALLENGE only supports SAFECOOKIE authentication%

+1:43% nc localhost 9100
AUTHCHALLENGE SAFECOOKIE FOOFA
513 Invalid base16 client nonce%

That is all.

changed milestone to %Tor: 0.2.2.x-final in legacy/trac

added component::core tor/tor in Legacy / Trac easy in Legacy / Trac milestone::Tor: 0.2.2.x-final in Legacy / Trac owner::neena in Legacy / Trac priority::high in Legacy / Trac resolution::fixed in Legacy / Trac status::closed in Legacy / Trac tor-client in Legacy / Trac type::defect in Legacy / Trac version::tor 0.2.3.15-alpha in Legacy / Trac labels

My branch fixing this is here

http://repo.or.cz/w/tor/neena.git/shortlog/refs/heads/fix-5760

Trac:
Owner: N/A to neena
Status: new to assigned

Trac:
Status: assigned to needs_review

Trac:
Milestone: N/A to Tor: 0.2.2.x-final
Priority: normal to major

The patch looks good! (It'll need to be cherry-picked or rebased onto maint-0.2.2, though.)

and a changes file (since the feature is already released in the 0.2.3 branch). rransom, maybe you can help make it something mergeable?

cherry-picked for maint-0.2.2 here

http://repo.or.cz/w/tor/neena.git/shortlog/refs/heads/fix-5760-maint-0.2.2

I have added a changes/bug5760 file to both the branches. I'm not sure if it is missing anything.

Looks okay to me. Thanks, neena! Merging into 0.2.2 and forward.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

In the changes file, when you say "bugfix on 0.2.3.16-alpha", you're supposed to say the Tor version that introduced the bug, not the Tor version that you hope will include your fix.

Looks like it was a bugfix on 0.2.2.36 and 0.2.3.13-alpha.

Trac:
Keywords: easy deleted, easy tor-client added

Trac:
Component: Tor Client to Tor

closed

moved from legacy/trac#5760 (moved)

added Bug First Contribution labels and removed 1 deleted label

added Client label and removed 1 deleted label