Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 326
    • Issues 326
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #681
Closed
Open
Issue created May 08, 2008 by Roger Dingledine@armaReporter

encrypted dir conns confuse LeaveStreamsUnattached

(This is Mikeperry's bug)

When we launch an encrypted dir conn in directory.c via connection_ap_make_link(), it'll put the stream in state AP_CONN_STATE_CIRCUIT_WAIT. This means that even controllers that set LeaveStreamsUnattached won't need to handle it, since it's already being handled.

Bug #1: controllers don't know this, and can't distinguish streams that are already being handled. Mike had a patch to put an extra flag on the stream status line.

Bug legacy/trac#2 (closed): then if the stream causes a circuit to get created, and gets attached to that circuit, but the circuit times out or otherwise fails to fulfill the request, the stream will be handled by connection_ap_detach_retriable() which will set it to state AP_CONN_STATE_CONTROLLER_WAIT. And the controller doesn't realize that this time it's supposed to handle it (and it probably shouldn't need to handle it)

[Automatically added by flyspray2trac: Operating System: All]

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking