tor-0.2.4.x compilation with FreeBSD gcc

FreeBSD 8.3+ i386 gcc 4.2.1+

tor-0.2.3.25 is fine

tor-0.2.4.15 src/or/circuitlist.c:1522: warning: passing argument 1 of 'TO_OR_CIRCUIT' discards qualifiers from pointer target type

master 6848e293 src/or/circuitlist.c:1647: warning: passing argument 1 of 'TO_OR_CIRCUIT' discards qualifiers from pointer target type

changed milestone to %Tor: 0.2.4.x-final in legacy/trac

added build in Legacy / Trac component::core tor/tor in Legacy / Trac freebsd in Legacy / Trac milestone::Tor: 0.2.4.x-final in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac status::closed in Legacy / Trac tor-client in Legacy / Trac type::defect in Legacy / Trac version::tor 0.2.4.15-rc in Legacy / Trac warning in Legacy / Trac labels

Strange! The code in question is

    n += TO_OR_CIRCUIT((circuit_t*)c)->p_chan_cells.n;

And that warning usually means that you're calling TO_OR_CIRCUIT with a const pointer when it only takes a non-const one. But we are calling it with a non-const pointer -- we're casting c to circuit_t*.

This warning doesn't seem to occur on other platforms, as far as I know. Could the FreeBSD gcc be doing something unusual here?

Could the FreeBSD gcc be doing something unusual here? That I don't know. FreeBSD typically uses older gcc's for their base, backport select gcc patches into it, and do what they need for FreeBSD.

I just checked and this warning goes away when using gcc 4.6.4 from their packages (added CC and CPP env vars to the 4.6.4 bins).

Trac:
Summary: tor-0.2.4.x compilation to tor-0.2.4.x compilation with FreeBSD gcc

FWIW, I can't reproduce that warning on a FreeBSD 8.3 amd64 (!) system with gcc 4.2.1.

Trac:
9254.patch

possible fix for legacy/trac#9254 (moved)

Does the attached patch (against maint-0.2.4) fix the compilation warning for you?

Trac:
Status: new to needs_review

This was on a 'Jul 2012 RELENG_8 i386' with its 'gcc 4.2.1 20070831 patched [FreeBSD]'.

The attached patch as applied to the rc tarball fixes the warning there.

Fixed in c36bdbd5. Thanks!

Trac:
Status: needs_review to closed
Keywords: N/A deleted, tor-client freebsd build warning added
Resolution: N/A to fixed

closed

moved from legacy/trac#9254 (moved)

added Bug label and removed 1 deleted label

added Build Client labels and removed 1 deleted label